Skip to content

Conversation

@coretl
Copy link
Contributor

@coretl coretl commented Jul 15, 2025

Also deprecate aioca.run so we don't need to change it

Fixes #60

coretl and others added 2 commits July 15, 2025 14:54
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (b04469b) to head (1f049d8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   99.33%   99.34%           
=======================================
  Files           4        4           
  Lines         453      455    +2     
=======================================
+ Hits          450      452    +2     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, with the caveat that I think this is a major API change: If anyone was depending on aioca to make the event loop then the behaviour has changed.

Also requesting the added comment to refer to issue #62 .

coretl and others added 2 commits July 17, 2025 10:58
@AlexanderWells-diamond AlexanderWells-diamond merged commit 78bdc91 into main Jul 24, 2025
31 checks passed
@AlexanderWells-diamond AlexanderWells-diamond deleted the get-running-loop branch July 24, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing behaviour when there is no running event loop

3 participants