-
Notifications
You must be signed in to change notification settings - Fork 5
chore: Update supported Python versions through copier template update #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update supported Python versions through copier template update #59
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 4 4
Lines 455 457 +2
=======================================
+ Hits 452 454 +2
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I would recommend rejecting this PR merely based on the title and description. Please fix this and the corresponding commit description. Updating the python requirement should definitely be a commit of its own. |
|
This repo also maintains a |
|
@AlexanderWells-diamond I've added a changelog entry- it looks like the change of supporting 3.13 will need to be continued upstream to epicscorelibs. This has come from wanting to support Python 3.13 in blueapi/dodal/ophyd-async in keeping with the NumPy deprecation policy. @Araneidae the Python version support is defined in a section of the pyproject.toml that is modified by the python copier template in this update. To keep the tooling compatible and up to date, to allow future automating of updates and to prevent merge conflicts with all future updates to either, I'd like to keep them both together. Propagating those changes from the template means the whole organisation can move forward faster. |
|
I've left this as a draft as epicscorelibs support is still required |
dab7661 to
367ef36
Compare
The Copier template will handle generating the changelog for us as part of making releases
We can't do any releases without all tests passing, so we're removing this failing test matrix configuration. See issue DiamondLightSource#63.
|
I've made a few tweaks to this PR:
|
f694479
into
DiamondLightSource:main
Adds support for Python 3.13 and drops for Python <=3.10 following the Numpy deprecation policy, and keeps dependencies, CI and infrastructure up to date with Diamond standards.
Instructions to reviewer on how to test:
Checks for reviewer