-
Notifications
You must be signed in to change notification settings - Fork 5
Fix clashing contexts #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The CI failures here will be fixed by the changes that I'm working on in #50 |
|
Are you happy to merge despite the CI failures @coretl? |
|
@AlexanderWells-diamond how close are your CI updates? We can either merge and release this as is (possibly disabling tests to get it to publish), or wait for your updates? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
===========================================
- Coverage 100.00% 99.33% -0.67%
===========================================
Files 4 4
Lines 446 453 +7
===========================================
+ Hits 446 450 +4
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. |
|
Discussed with @coretl, he's happy to merge without full coverage |
See also the test in bluesky/ophyd-async#600