refactor: enable unwrap_used clippy correctness lint
#965
Conversation
|
|
||
| const WIDTH: NonZeroU16 = NonZeroU16::new(2048).expect("value is guaranteed to be non-zero"); | ||
| const HEIGHT: NonZeroU16 = NonZeroU16::new(2048).expect("value is guaranteed to be non-zero"); | ||
| // QUESTION: It looks like we have a bug here, don't we? The stride value should be 2048 * 4. |
There was a problem hiding this comment.
Hi @elmarco! Could you help with clarifying this one? It seems it has been modified by you.
Coverage Report 🤖 ⚙️Past: New: Diff: -0.04% [this comment will be updated automatically] |
RRRadicalEdward
force-pushed
the
add-unwrap-used-clippy-lint
branch
from
facb96d to
8a353a9
Compare
|
Out of blue, cargo xtask check lints started to report that there are still warnings. Let me fix them as well. EDIT: |
RRRadicalEdward
force-pushed
the
add-unwrap-used-clippy-lint
branch
from
523ea79 to
dc47d82
Compare
|
Hi @CBenoit! This one is ready to be merged. Is there anything left for me to do? |
| /// `tokio::select!` statement. If some other branch completes first, it | ||
| /// MUST be guaranteed that no data is lost. | ||
| async fn next_update(&mut self) -> Option<DisplayUpdate>; | ||
| async fn next_update(&mut self) -> Result<Option<DisplayUpdate>>; |
There was a problem hiding this comment.
note: This is a breaking change, this should typically be treated with care (and should surface in the changelog). I’ll handle that manually on my hand before merging the release PR this time.
2 participants
#964 has to be merged first