feat(ffi): integrate Devolutions.IronRDP with RDCleanPath #1014

irvingoujAtDevolution · 2025-10-07T21:16:37Z

Add RDCleanPath support for Devolutions.IronRDP .NET package

- Add RDCleanPath FFI bindings - Implement WebSocket stream for gateway connections - Add GatewayConnection API with CredSSP hostname extraction - Support both direct and gateway connection modes

Add KerberosConfig FFI bindings and HTTP/HTTPS network protocol handling for KDC proxy authentication via Devolutions Gateway. - Expose KerberosConfig::new() in FFI layer - Add GenerateKdcToken() method to TokenGenerator - Update GatewayConnection to accept KDC proxy parameters - Implement HTTP/HTTPS request handling in ResolveGenerator - Auto-generate client hostname for Kerberos authentication 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

github-actions · 2025-10-07T21:22:17Z

Coverage Report 🤖 ⚙️

Past:
Total lines: 26124
Covered lines: 15317 (58.63%)

New:
Total lines: 26124
Covered lines: 15313 (58.62%)

Diff: -0.02%

[this comment will be updated automatically]

Copilot

Pull Request Overview

This PR integrates Devolutions.IronRDP with Gateway by adding RDCleanPath protocol support and KDC proxy capabilities for .NET. The implementation enables RDP connections through Devolutions Gateway using WebSocket transport with optional Kerberos authentication via KDC proxy.

Adds RDCleanPath protocol FFI bindings for gateway communication
Implements KDC proxy support for Kerberos authentication through the gateway
Provides WebSocket transport layer and gateway connection methods for .NET

Reviewed Changes

Copilot reviewed 14 out of 36 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ffi/src/rdcleanpath.rs	Adds FFI bindings for RDCleanPath protocol operations
ffi/src/lib.rs	Registers new rdcleanpath module
ffi/src/error.rs	Adds error handling for RDCleanPath and DER operations
ffi/src/credssp/mod.rs	Extends KerberosConfig with KDC proxy support
ffi/dotnet/Devolutions.IronRdp/src/WebsocketStream.cs	Implements WebSocket stream adapter for network transport
ffi/dotnet/Devolutions.IronRdp/src/GatewayConnection.cs	Provides gateway connection methods using RDCleanPath
ffi/dotnet/Devolutions.IronRdp/src/Framed.cs	Adds custom PDU hint interface for flexible frame detection
ffi/dotnet/Devolutions.IronRdp/src/Connection.cs	Updates connection logic to support HTTP/HTTPS requests for KDC proxy
ffi/dotnet/Devolutions.IronRdp.ConnectExample/Program.cs	Updates example to remove unused parameter
ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/TokenGenerator.cs	Adds JWT token generation client for gateway authentication
ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs	Integrates gateway connection support in example application
ffi/dotnet/Devolutions.IronRdp.ConnectExample/Devolutions.IronRdp.ConnectExample.csproj	Updates ImageSharp package version
ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/Devolutions.IronRdp.AvaloniaExample.csproj	Updates Avalonia package versions
ffi/Cargo.toml	Adds ironrdp-rdcleanpath dependency

Comments suppressed due to low confidence (1)

ffi/dotnet/Devolutions.IronRdp/src/Connection.cs:129

[nitpick] Use conventional null comparison style 'decoded == null' instead of Yoda condition 'null == decoded' for better readability and consistency with C# conventions.

            if (null == decoded)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ffi/src/rdcleanpath.rs

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

ffi/src/rdcleanpath.rs

ffi/src/error.rs

CBenoit · 2025-10-08T08:37:03Z

Please, open a separate PR for the KDC proxy part.

ffi/dotnet/Devolutions.IronRdp/src/GatewayConnection.cs

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 39 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ffi/src/rdcleanpath.rs

Co-authored-by: Copilot <[email protected]>

…o gateway-with-ffi

irvingoujAtDevolution · 2025-10-08T18:49:35Z

ffi/src/clipboard/mod.rs

-        if let Err(err) = self.sender.send(message) {
-            error!("Failed to send clipboard message: {:?}", err);
+        if let Err(error) = self.sender.send(message) {
+            error!(?error, "Failed to send clipboard message");


Just fixing styles along the way, let me know if you mind

irvingoujAtDevolution · 2025-10-08T18:49:51Z

ffi/src/connector/mod.rs

        }

        pub fn with_dynamic_channel_display_control(&mut self) -> Result<(), Box<IronRdpError>> {
            self.with_dvc(DisplayControlClient::new(|c| {


Just fixing styles along the way, let me know if you mind

irvingoujAtDevolution · 2025-10-08T19:32:39Z

Ready for review @CBenoit

CBenoit · 2025-10-16T12:49:57Z

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

    ActiveStage? _activeStage;
    DecodedImage? _decodedImage;
-    Framed<SslStream>? _framed;
+    Framed<Stream>? _framed;  


suggestion: Run dotnet format

CBenoit · 2025-10-16T12:51:24Z

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs

        var username = Environment.GetEnvironmentVariable("IRONRDP_USERNAME");
        var password = Environment.GetEnvironmentVariable("IRONRDP_PASSWORD");
-        var domain = Environment.GetEnvironmentVariable("IRONRDP_DOMAIN");
+        var domain = Environment.GetEnvironmentVariable("IRONRDP_DOMAIN"); // Optional


suggestion: Inconsistent. IRONRDP_DOMAIN is not the only optional env variable. IRONRDP_PORT is too. Either document what is required and what is not consistently, or remove the outdated comment for now.

Suggested change

var domain = Environment.GetEnvironmentVariable("IRONRDP_DOMAIN"); // Optional

var domain = Environment.GetEnvironmentVariable("IRONRDP_DOMAIN");

CBenoit · 2025-10-17T00:10:45Z

ffi/dotnet/Devolutions.IronRdp/src/RDCleanPathConnection.cs

+    /// <param name="pcb">Optional preconnection blob for Hyper-V VM connections</param>
+    /// <param name="factory">Optional clipboard backend factory</param>
+    /// <returns>A tuple containing the connection result and framed WebSocket stream</returns>
+    public static async Task<(ConnectionResult, Framed<WebSocketStream>)> ConnectViaGateway(


suggestion: I suggest a more generic naming here: ConnectRDCleanPath. Try to see if there are other similar places.

CBenoit · 2025-10-17T00:24:04Z

ffi/dotnet/Devolutions.IronRdp/src/RDCleanPathConnection.cs

+        // Step 2: Get client local address (dummy for WebSocket)
+        string clientAddr = "127.0.0.1:33899";


note: I guess this is fine? But that’s not what we do in the Rust native client. Look for the connect_ws function.

CBenoit · 2025-10-17T00:44:56Z

ffi/src/error.rs

+pub struct GenericError(pub anyhow::Error);
+
+impl Display for GenericError {
+    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
+        write!(f, "{:#}", self.0)
+    }
+}
+
+impl From<GenericError> for IronRdpErrorKind {
+    fn from(_val: GenericError) -> Self {
+        IronRdpErrorKind::Generic
+    }
+}


note: This can be made less verbose to write, and the IronRdpErrorKind type can be removed. Will be a follow up from me.

CBenoit · 2025-10-17T00:46:45Z

ffi/src/rdcleanpath.rs

+        }
+
+        /// Converts the PDU into a typed enum for pattern matching
+        pub fn into_enum(&self) -> Result<Box<RDCleanPathResult>, Box<IronRdpError>> {


naming: In the FFI, we do not return an enum. Actually, I don’t think you need a whole different type, it’s not useful here since we can’t manipulate field by field, and there is no destructuring pattern matching.

CBenoit · 2025-10-17T00:50:03Z

ffi/src/rdcleanpath.rs

+        /// Returns 0 if not present or not a GeneralError variant
+        pub fn get_http_status_code(&self) -> u16 {


suggestion: Instead of the magic number, can this be Option? (Nullable u16)

irvingoujAtDevolution and others added 4 commits October 7, 2025 16:07

feat(ffi): add RDCleanPath gateway support for .NET

e3c5969

- Add RDCleanPath FFI bindings - Implement WebSocket stream for gateway connections - Add GatewayConnection API with CredSSP hostname extraction - Support both direct and gateway connection modes

clean up

61aa07f

clean up

20c360b

irvingoujAtDevolution requested a review from CBenoit October 7, 2025 21:17

CBenoit requested a review from Copilot October 8, 2025 08:21

Copilot AI reviewed Oct 8, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Show resolved Hide resolved

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/src/error.rs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp/src/GatewayConnection.cs Outdated Show resolved Hide resolved

CBenoit reviewed Oct 8, 2025

View reviewed changes

ffi/dotnet/Devolutions.IronRdp.AvaloniaExample/MainWindow.axaml.cs Outdated Show resolved Hide resolved

irvingoujAtDevolution and others added 3 commits October 8, 2025 11:38

Apply suggestion from @Copilot

14f662c

Co-authored-by: Copilot <[email protected]>

Apply suggestion from @Copilot

4be6d68

Co-authored-by: Copilot <[email protected]>

fix

2fba10a

irvingoujAtDevolution changed the title ~~feat(ffi): intergrate Devolutions.IronRDP with Gateway~~ feat(ffi): integrate Devolutions.IronRDP with Gateway Oct 8, 2025

irvingoujAtDevolution added 3 commits October 8, 2025 12:45

clean

fc60212

review fix

8f0a3b7

review fix

57f7f4e

irvingoujAtDevolution changed the title ~~feat(ffi): integrate Devolutions.IronRDP with Gateway~~ feat(ffi): integrate Devolutions.IronRDP with RDCleanPath Oct 8, 2025

irvingoujAtDevolution requested a review from Copilot October 8, 2025 17:11

Copilot AI reviewed Oct 8, 2025

View reviewed changes

ffi/src/rdcleanpath.rs Show resolved Hide resolved

irvingoujAtDevolution and others added 5 commits October 8, 2025 13:30

review fix

5534d15

Update ffi/src/rdcleanpath.rs

cc14045

Co-authored-by: Copilot <[email protected]>

Merge branch 'gateway-with-ffi' of github.com:Devolutions/IronRDP int…

051380c

…o gateway-with-ffi

strip off kdc proxy

ecdf6f4

remove proxy

a26cc97

irvingoujAtDevolution requested a review from CBenoit October 8, 2025 18:39

undo changes

1889c12

irvingoujAtDevolution commented Oct 8, 2025

View reviewed changes

irvingoujAtDevolution added 3 commits October 8, 2025 14:53

clean up

7072206

clean up

a1e3551

clean up

c54e496

CBenoit reviewed Oct 16, 2025

View reviewed changes

CBenoit reviewed Oct 17, 2025

View reviewed changes

	var domain = Environment.GetEnvironmentVariable("IRONRDP_DOMAIN"); // Optional
	var domain = Environment.GetEnvironmentVariable("IRONRDP_DOMAIN");

		// Step 2: Get client local address (dummy for WebSocket)
		string clientAddr = "127.0.0.1:33899";

		/// Returns 0 if not present or not a GeneralError variant
		pub fn get_http_status_code(&self) -> u16 {

feat(ffi): integrate Devolutions.IronRDP with RDCleanPath #1014

Are you sure you want to change the base?

feat(ffi): integrate Devolutions.IronRDP with RDCleanPath #1014

Uh oh!

Conversation

irvingoujAtDevolution commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 🤖 ⚙️

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CBenoit commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

irvingoujAtDevolution Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

irvingoujAtDevolution Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

irvingoujAtDevolution commented Oct 8, 2025

Uh oh!

CBenoit Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CBenoit Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

irvingoujAtDevolution commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

CBenoit commented Oct 8, 2025 •

edited

Loading

CBenoit Oct 16, 2025 •

edited

Loading

CBenoit Oct 17, 2025 •

edited

Loading

CBenoit Oct 17, 2025 •

edited

Loading