SSE Proxy Functionality - FDN-17 FDN-233 FDN-234 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| | DVC_LB_PROXY_SDKCONFIG_EVENTSAPIURI | String | | | The URI of the Events API - leave unspecified if not needing an outbound proxy. | | ||
| | KEY | TYPE | DEFAULT | REQUIRED | DESCRIPTION | | ||
| |----------------------------------------------------------|---------------|---------|----------|---------------------------------------------------------------------------------| | ||
| | DEVCYCLE_PROXY_CONFIG | String | | | The path to a JSON configuration file. | |
Member
There was a problem hiding this comment.
Will we need to do a major version increase for these name changes?
| func Variable(client *devcycle.Client) gin.HandlerFunc { | ||
| func Variable() gin.HandlerFunc { | ||
| return func(c *gin.Context) { | ||
| client := c.Value("devcycle").(*devcycle.Client) |
Member
There was a problem hiding this comment.
ohh, interesting so the devcycle client is now attached to the request context?
Member
Author
There was a problem hiding this comment.
Yeah - I wanted to make it more context friendly and properly scoped to each request since it's handled by a different gin instance
jonathannorris
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.