Skip to content

feat: Wrap read_event in exception handling #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: Wrap read_event in exception handling #84

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b2964
Wrap read_event in exception handling
ja5087 Apr 17, 2025
4ec9ec5
Update devcycle_python_sdk/managers/sse_manager.py
jonathannorris Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions devcycle_python_sdk/managers/sse_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@

import ld_eventsource
import ld_eventsource.actions
import logging
import ld_eventsource.config
from typing import Callable

logger = logging.getLogger(__name__)


class SSEManager:
def __init__(
Expand All @@ -31,13 +34,16 @@ def read_events(
handlemessage: Callable[[ld_eventsource.actions.Event], None],
):
self.client.start()
for event in self.client.all:
if isinstance(event, ld_eventsource.actions.Start):
handlestate(event)
elif isinstance(event, ld_eventsource.actions.Fault):
handleerror(event)
elif isinstance(event, ld_eventsource.actions.Event):
handlemessage(event)
try:
for event in self.client.all:
if isinstance(event, ld_eventsource.actions.Start):
handlestate(event)
elif isinstance(event, ld_eventsource.actions.Fault):
handleerror(event)
elif isinstance(event, ld_eventsource.actions.Event):
handlemessage(event)
except Exception as e:
logger.exception(f"DevCycle: failed to read SSE message: {e}")

def update(self, config: dict):
if self.use_new_config(config["sse"]):
Expand Down
Loading