Skip to content

DVC-7684 New Cloud SDK #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Jun 13, 2023
Merged

DVC-7684 New Cloud SDK #20

merged 53 commits into from
Jun 13, 2023

Conversation

chris-hoefgen
Copy link
Contributor

Replaced the code-generated version of the SDK with a new version build from scratch using Python Request objects

  • Added unit tests
  • Updated SDK to match test harness expectations
  • Refactored imports
  • Updated examples and README

chris-hoefgen and others added 30 commits June 8, 2023 10:56
blocking out a new cloud client
857b856
minor tidy
9ec436d
fixed some bugs
5a28f2a
format change
ab7152b
remove useless unit tests
0631876
adding new unit tests
46e2519
bug fix - file not getting closed
6370a89
ripping out the old cloud api and dependencies
fbce696
adding unit test github action
22c9275
fixing error
766c100
another attempt to fix unit test in GHA
3b3face
testing against older versions again
3d05e91
pin tests to python 3.10 for now
b168195
reverting some changes
3afb881
partial version of bucketing API client
01ecb99
implement variables and features methods
f60d5f1
implement tracking of events
85e1368
activating new bucketing api, converting all models to data classes, …
0c70ac6 
…tweaking example
wire up event tracking
7efd17d
forgot to remove unused data object
8b98fbe
add retries with exponential backoff
a0e4b97
removed another unused model class
2796484
Merge branch 'DVC-7684-new-cloud-sdk' of github.com:DevCycleHQ/python…
e436f63 
…-server-sdk into DVC-7684-new-cloud-sdk
revised the readme
d9eb7d4
removed error I added but never used
aec9a15
update error handling to handle 4xx errors correctly
c587d55
update setup.py to use latest requirements
702db29
bugfix
b7f1040
removed extra fields because they don't match cloud test harness pattern
9ce5ce6
Merge branch 'DVC-7684-new-cloud-sdk' of github.com:DevCycleHQ/python…
8f9e1ca 
…-server-sdk into DVC-7684-new-cloud-sdk
Rob ODwyer and others added 20 commits June 9, 2023 15:23
fix handling of 5xx errors
881433a
cleaned up some code to better match test harness expecatations
c1941c3
Merge branch 'DVC-7684-new-cloud-sdk' of github.com:DevCycleHQ/python…
f769849 
…-server-sdk into DVC-7684-new-cloud-sdk
start of some long overdue tests for the bucketing client
842ee3e
assorted bug fixes for test harness compliance
249aeaa
return defaultValue in defaulted variables
6552f69
check that variable value matches default
7e9afc7
rounded out unit tests for the cloud client to eval error handling an…
20eafce 
…d return values
Added sdk type to user data
876eabe
add edgedb option to query
bb31640
fix some warning messages
5c2ec53
exclude isDefaulted field from variables responses
67016db
update lint rules and fix some naming
2f96dc5
update setup.py
06d03f1
readme update
a8e800d
add placeholder GHA for test harness
5ec7d20
Moved the client and cleaned up the imports to be much more simple an…
a4cf8f2 
…d explicit - only shortcuts for options and client classes
fixed import in the readme
3ab5cf4
allow configuring the retry delay
8573593
add tests to bucketing client for retries
7b49aad
@chris-hoefgen chris-hoefgen marked this pull request as draft June 13, 2023 14:55
@chris-hoefgen chris-hoefgen marked this pull request as ready for review June 13, 2023 17:26
@chris-hoefgen chris-hoefgen requested a review from rob-odwyer June 13, 2023 17:26
@chris-hoefgen chris-hoefgen merged commit 8549d0c into main Jun 13, 2023
@rob-odwyer rob-odwyer deleted the DVC-7684-new-cloud-sdk branch July 13, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rob-odwyer rob-odwyer rob-odwyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-hoefgen @rob-odwyer