feat: add eval reasons to WASM Bucketing #1091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
phaym
changed the title
phaym
commented
Jun 17, 2025
| @@ -355,13 +345,16 @@ describe('SegmentationManager Unit Test', () => { | |||
| platformVersion: '2.0.0', | |||
| platform: 'iOS', | |||
| } | |||
| assert.strictEqual(false, evaluateOperator({ data, operator })) | |||
| assert.deepStrictEqual( | |||
There was a problem hiding this comment.
all of the assertions in this file have the argument backwards, not sure i should fix in this PR since the changes here are crazy enough
phaym
force-pushed
the
feat/assembly-eval-reasons-2
branch
from
39d817d to
bd37a49
Compare
|
recreating with av |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Eval Reasons" to Variables and Features to report what condition trigger a variation to be served, similar to changes for js library in #1085.