Skip to content

feat: add eval reasons support #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 28, 2025
Merged

feat: add eval reasons support #181

merged 24 commits into from
Jul 28, 2025

Conversation

@phaym
Copy link
Contributor

@phaym phaym commented Jul 22, 2025 •
edited
Loading

Eval reason support for dotnet sdk

OpenFeature and Event support to come in future PR.

@phaym
Copy link
Contributor Author

phaym commented Jul 22, 2025

@JamieSinn this ones very much WIP still, just publishing a draft to share to jason

@JamieSinn
Copy link
Member

Github mobile for some reason bugged and reviewed this pr instead of Jonathans. Weird

JamieSinn
JamieSinn requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@JamieSinn JamieSinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing approval

@JamieSinn JamieSinn self-requested a review July 22, 2025 17:54
@phaym phaym changed the title log eval reason feat: add eval reaons support Jul 22, 2025
@phaym phaym changed the title feat: add eval reaons support feat: add eval reasons support Jul 22, 2025
@phaym phaym marked this pull request as ready for review July 24, 2025 17:05
@phaym phaym requested a review from a team as a code owner July 24, 2025 17:05
JamieSinn
JamieSinn reviewed Jul 24, 2025
View reviewed changes
@phaym phaym requested review from a team and JamieSinn July 24, 2025 18:14
JamieSinn
JamieSinn reviewed Jul 28, 2025
View reviewed changes
@phaym phaym merged commit 1a1d2ba into main Jul 28, 2025
9 checks passed
@phaym phaym deleted the feat/eval-reasons branch July 28, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamieSinn JamieSinn JamieSinn approved these changes

@jsalaber jsalaber jsalaber approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phaym @JamieSinn @jsalaber