Skip to content

Only bundle the officially released binaries #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2022
Merged

Only bundle the officially released binaries #380

merged 7 commits into from
Mar 3, 2022

Conversation

fundthmcalculus
Copy link
Contributor

No description provided.

@fundthmcalculus fundthmcalculus marked this pull request as draft March 3, 2022 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Python Test Report

  12 files  ±0    12 suites  ±0   14s ⏱️ -1s
  12 tests ±0    12 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
144 runs  ±0  144 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d2b64f3. ± Comparison against base commit c3b5b9f.

♻️ This comment has been updated with latest results.

@fundthmcalculus fundthmcalculus marked this pull request as ready for review March 3, 2022 15:53
@fundthmcalculus fundthmcalculus mentioned this pull request Mar 3, 2022
Closed
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Java Test Report

12 files  ±0  12 suites  ±0   1s ⏱️ ±0s
17 tests ±0  17 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
39 runs  ±0  39 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d2b64f3. ± Comparison against base commit c3b5b9f.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
OkapiNativeTest ‑ [1] OkapiNativeTest$DataArgument@c94fd30
OkapiNativeTest ‑ [2] OkapiNativeTest$DataArgument@386f0da3

OkapiNativeTest ‑ [1] OkapiNativeTest$DataArgument@34c01041
OkapiNativeTest ‑ [2] OkapiNativeTest$DataArgument@2e1ef60

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

.NET Test Report

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit d2b64f3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Ruby Test Report

  36 files  ±0    36 suites  ±0   2s ⏱️ ±0s
  12 tests ±0    12 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
108 runs  ±0  108 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d2b64f3. ± Comparison against base commit c3b5b9f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022 •
edited
Loading

Golang Test Report

  3 files    3 suites   0s ⏱️
14 tests 14 ✔️ 0 💤 0 ❌
42 runs  42 ✔️ 0 💤 0 ❌

Results for commit d2b64f3.

♻️ This comment has been updated with latest results.

@fundthmcalculus fundthmcalculus marked this pull request as draft March 3, 2022 16:00
@fundthmcalculus fundthmcalculus temporarily deployed to nuget.org March 3, 2022 16:45 Inactive
@fundthmcalculus fundthmcalculus marked this pull request as ready for review March 3, 2022 17:10
@fundthmcalculus fundthmcalculus changed the title Download binaries so we can bundle them Only bundle the officially released binaries Mar 3, 2022
@fundthmcalculus fundthmcalculus merged commit 85ef8ab into main Mar 3, 2022
@fundthmcalculus fundthmcalculus deleted the python-download-binaries branch March 3, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkovski tmarkovski tmarkovski approved these changes

@michaeldboyd michaeldboyd Awaiting requested review from michaeldboyd

@MichaelEdwardBlack MichaelEdwardBlack Awaiting requested review from MichaelEdwardBlack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundthmcalculus @tmarkovski