Skip to content

Add types for web3-eth-abi #26127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LogvinovLeon
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 30, 2018

@LogvinovLeon Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels May 30, 2018
@DanielRosenwasser DanielRosenwasser merged commit 1e78de3 into DefinitelyTyped:master May 30, 2018
@levino
Copy link
Contributor

levino commented May 30, 2018

I am not sure that this is the right approach. web3-eth-abi is a more or less a subpackage of web3. So maybe it makes more sense to type the whole web3-* family in one go. Also web3 provides its own, currently broken type definitions. In principle this means that there generally is some kind of "intend" to also provide typings to the subpackages. Either way I think all definitions for the web3 submodules should be either maintained here or over at the web3 repo.

I think this PR was accepted without reviewing in depth and without having a proper plan for the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants