Unit Testing: Do no run in debug mode in order to reduce logging #13241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewing a failed test in the GHA logs is not very helpful without rendering the raw view because there are 50k+ lines of debug logs. Reducing the logging verbosity would make the tests quite a bit faster as well as finding failures easier in the GHA UI
|
When I look at the output of tests the biggest generators of output are the vcr related tests. Maybe a rerecording will reduce the output? There's also some dedupe and false positives history tests which put out lots of logging. Maybe those log statements can be commented out. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Yep - they are debug logging the entire request 🥴 I would prefer to keep those logs in case someone needs them. not sure why the tests are ignoring the log level. Will make more time for this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewing a failed test in the GHA logs is not very helpful without rendering the raw view because there are 50k+ lines of debug logs. Reducing the logging verbosity would make the tests quite a bit faster as well as finding failures easier in the GHA UI