-
Notifications
You must be signed in to change notification settings - Fork 1.7k
🎉 Add fix_available to KrakenDAudit #13055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Add fix_available to KrakenDAudit #13055
Conversation
This pull request contains a potential misinformation issue in the KrakenD audit report parser, where the code incorrectly hardcodes
Incorrect State Reporting / Misinformation in
|
Vulnerability | Incorrect State Reporting / Misinformation |
---|---|
Description | The code hardcodes fix_available=True for all findings parsed from KrakenD audit reports. This is problematic because it assumes a fix is always available, which is unlikely to be true for all security findings. This can mislead users about the true remediation status of vulnerabilities, potentially causing them to misprioritize remediation efforts or giving a false sense of security. |
django-DefectDojo/dojo/tools/krakend_audit/parser.py
Lines 29 to 35 in 3cb19c7
mitigation=message, | |
static_finding=True, | |
dynamic_finding=False, | |
fix_available=True, | |
) | |
findings.append(finding) | |
return findings |
All finding details can be found in the DryRun Security Dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
#12633 (comment)
I removed also the mitigation from dedeuplication as this was only there to close the old finding in case the mitigation becomes available.