FileUploads: Clean up media when related objects are deleted
#13028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
New Migration
Maffooch
commented
Aug 21, 2025
blakeaowens
approved these changes
Aug 22, 2025
valentijnscholten
approved these changes
Aug 24, 2025
dogboat
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation creates orphaned file upload objects that are never cleaned up when their parents are deleted. We should be deleting the FileUpload objects when their associated objects are deleted, and cleaning the media directory when applicable. This PR adds functionality for this as well as a one time migration to clean up all existing orphaned files