Fixes a bug in srun_fastsurfer that processed the partition argument wrong #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrong. Partition was read, but passed to sbatch as "-p <partition>" instead of as "-p" "<partition>" srun_fastsurfer.sh - Fix the variable assignments of slurm_partition - Use first_non_empty instead of first_non_empty_partition stools.sh - Remove the first_non_empty_partition function.
dkuegler
force-pushed
the
fix/srun-partition
branch
from
b9e8b0c to
967bc20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partition was read, but passed to
sbatchas "-p " instead of as "-p" ""This PR addresses a BUG reported in #580.
srun_fastsurfer.sh
stools.sh