Skip to content

Conversation

@dkuegler
Copy link
Member

@dkuegler dkuegler commented Aug 23, 2024

This PR updates the versions and code of python packages and cuda in the docker build environment to most recent versions.
Some warnings because of deprecation or unsafe behaviors (that should not affect FastSurfer, because we do not download and use unsafe checkpoints) are also fixed.

This PR is rebased on #559.

Validation testing is running for this version (admittedly on the version before the fix to the torch warning (last commit)).

@m-reuter
Copy link
Member

and we need to test if the new rocm works.

@m-reuter
Copy link
Member

More questions:

  • requirements.txt has not been updated accordingly
  • are all packages on the newest versions? for example numpy is still not 2.* (of course we can postpone that, but should document here why some packages are not bumped and what needs to be done to do that later).

@dkuegler dkuegler force-pushed the version-bump branch 4 times, most recently from c41b8e2 to 66acc49 Compare August 27, 2024 08:28
taha-abdullah and others added 2 commits August 27, 2024 11:53
Add rocm as a valid device option to build.py
fix typo install_env.py for rocm
remove extra } in export_pip-r.sh
Fix Docker build for cuda 11.8
Add weights_only=True for torch.load to clean up torch warnings.
Fix delim_whitespace warning in data_utils.py
Fix AMD ROCm documentation.
@dkuegler dkuegler force-pushed the version-bump branch 2 times, most recently from 9f510ed to 0c7475e Compare August 28, 2024 08:53
@m-reuter
Copy link
Member

Problems in the doc build:

reading sources... [ 99%] scripts/segstats
:1: (WARNING/2) Inline literal start-string without end-string.

and

WARNING: 'myst' cross-reference target not found: 'README.md'

in a few md files.

@dkuegler dkuegler marked this pull request as draft August 29, 2024 10:09
@dkuegler dkuegler force-pushed the version-bump branch 2 times, most recently from 3926669 to b60716f Compare August 29, 2024 15:27
@dkuegler dkuegler marked this pull request as ready for review August 29, 2024 15:28
@dkuegler
Copy link
Member Author

This PR currently only needs an update of the requirements files, which I currently cannot generate.

export requirements.txt and requirements.cpu.txt from respective docker images
@m-reuter m-reuter merged commit 37a0b56 into Deep-MI:dev Sep 2, 2024
@dkuegler dkuegler deleted the version-bump branch September 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants