hotfix: --no_fs_t1 lower case #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So if you want to do the fix this way around (changing it in recon_surf.sh), the documentation needs to be updated as well. Both in recon_surf.sh and run_fastsurfer.sh the flag is described with upper case. Otherwise, it would have been easier to change it in run_fastsurfer.sh because this is the only place where the T was lower case. |
Member
Author
|
I thought, when we check for parameters, we always convert the input to lower case and then compare the strings in lower case format. That is why I changed it like this. |
Contributor
|
Ok, I see. Then it makes sense. I was not aware of the new changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #324