Use of full JSONC Parser

[Cielquan]

I use a JSONC file over JSON for my markdownlint-cli2 config to add comments.

In prettier via prettier/prettier#15553 a new jsonc parser was added, which is released but I think only in the 4.0 alpha. With this new parser prettier adds trailing commas to jsonc source. When I ran my QA toolchain, after updating the tools, markdownlint suddenly was throwing. The reason was, that the jsonc config (with trailing commas) could not be correctly parsed. I looked up the stacktrace and found the internal jsonc parser, which is at base just JSON.parse() which in turn does not allow trailing commas hence the issue. Based on this prettier/prettier#15553 (comment) it would propably be a good to utilize a fully fledged jsonc parser like https://github.com/microsoft/node-jsonc-parser?

[theoludwig]

I have the same issue, after upgrading my dependencies (notably prettier to v3.2.1 and markdownlint-cli2 to v0.12.0).
For now, the workaround is to downgrade Prettier to v3.1.1.

a new jsonc parser was added, which is released but I think only in the 4.0 alpha.

The new JSONC parser was added to Prettier v3.2.0 already, Changelog reference.

[DavidAnson]

This “hacky as hell and really terrible” approach has been in place since the beginning of the project in 2020 and hasn’t caused an issue in the four years since.

Until today when prettier opted everyone in.

Sorry for the inconvenience, I will look at addressing this soon.

db200da

[theoludwig]

Sorry for the inconvenience, I will look at addressing this soon.

No problem, and take your time! @DavidAnson ❤️
Thank you for your work, markdownlint and related is a incredibly useful tool!

(even VSCode have issues with trailing comma in .jsonc: microsoft/vscode#202422)

[mohamed2900]

I use a JSONC file over JSON for my markdownlint-cli2 config to add comments.

In prettier via prettier/prettier#15553 a new jsonc parser was added, which is released but I think only in the 4.0 alpha. With this new parser prettier adds trailing commas to jsonc source. When I ran my QA toolchain, after updating the tools, markdownlint suddenly was throwing. The reason was, that the jsonc config (with trailing commas) could not be correctly parsed. I looked up the stacktrace and found the internal jsonc parser, which is at base just JSON.parse() which in turn does not allow trailing commas hence the issue. Based on this prettier/prettier#15553 (comment) it would propably be a good to utilize a fully fledged jsonc parser like https://github.com/microsoft/node-jsonc-parser?