-
Notifications
You must be signed in to change notification settings - Fork 3
Improve CI pipeline #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI pipeline #252
Conversation
Signed-off-by: Marvin Froeder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR consolidates three separate GitHub Actions workflows (deploy.yml, uber-jar.yml, and presumably an earlier build workflow) into a single, more efficient build-and-test.yml workflow. The new structure implements a dependency-based execution model where a shared cache-dependencies job feeds into parallel test jobs, which then gate the deployment and artifact generation jobs.
Key changes:
- Introduces a dependency caching strategy to avoid redundant Maven dependency downloads across jobs
- Separates unit and integration tests into parallel jobs for faster feedback
- Makes deploy and uber-jar jobs run in parallel after tests pass, with test skipping via
-DskipTests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/uber-jar.yml | Removed standalone uber-jar workflow; functionality moved to build-and-test.yml |
| .github/workflows/deploy.yml | Removed standalone deploy workflow; functionality moved to build-and-test.yml |
| .github/workflows/build-and-test.yml | New consolidated workflow combining build, test, deploy, and uber-jar jobs with optimized dependency graph |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onfig to pluginManagement Signed-off-by: Marvin Froeder <[email protected]>
Signed-off-by: Marvin Froeder <[email protected]>
b694563 to
6841518
Compare
Signed-off-by: Marvin Froeder <[email protected]>
6841518 to
922151c
Compare
- Add setup-jdk composite action to centralize JDK 11 setup with Maven caching - Add setup-maven-settings composite action to centralize settings.xml generation - Replace actions/cache@v4 with built-in Maven caching from setup-java@v4 - Remove duplicate JDK setup blocks across all 5 jobs - Remove duplicate settings.xml generation in deploy and uber-jar jobs - Simplify deploy job conditional to be more explicit This reduces workflow lines from ~288 to ~219 (-69 lines) while improving maintainability by eliminating code duplication. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
9f61786 to
81cf511
Compare
Uh oh!
There was an error while loading. Please reload this page.