Make the runner more flexible for easier SQRL integration #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After integrating this into the
sqrlinfra, I ended up fine-tuning some things and adding a bit more logic here to make things more flexible.Main changes
CliRunnerthat is intended for standalone use, andJavaRunnerthat is intended for the SQRL test env. (Now that I wrote this, maybeSqrlRunneris a better name.)BaseRunnerabstract class.EnvVarResolverto a non-static utility, cause we need to inject environment variables on the SQRL side, and to keep that with the JSON deserializer, this seemed more appropriate.EnvVarResolver, that can be given via${KEY:defaultValue}.SqlExecutorthat puts UDFs into a user class loader, and adapt the Flink conf accordingly as well, cause theADD JARmethod does not work on the SQRL test env.