Return FlinkVectorType as a result in vector_embed in the OpenAI lib
#131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the vector_embed function and its tests to use FlinkVectorType instead of raw double[], and adds the vector-type dependency to the module.
- Change return types of
vectorEmbedandevalmethods fromdouble[]toFlinkVectorType - Update tests in
VectorEmbedTest.javato use AssertJ and handleFlinkVectorType - Add
vector-typemodule as a provided-scope dependency inpom.xml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| functions/openai-functions/src/test/java/com/datasqrl/flinkrunner/functions/openai/VectorEmbedTest.java | Updated future generics and assertions for FlinkVectorType. |
| functions/openai-functions/src/main/java/com/datasqrl/flinkrunner/stdlib/openai/vector_embed.java | Changed eval signature to accept CompletableFuture<FlinkVectorType>. |
| functions/openai-functions/src/main/java/com/datasqrl/flinkrunner/stdlib/openai/OpenAIEmbeddings.java | Changed embedding methods to return FlinkVectorType. |
| functions/openai-functions/pom.xml | Added vector-type dependency with provided scope. |
Comments suppressed due to low confidence (1)
functions/openai-functions/pom.xml:48
- Using
providedscope forvector-typemay exclude it from the final shaded runtime artifact, leading toNoClassDefFoundError. Consider usingcompilescope or adjusting the shade plugin to include this dependency.
<scope>provided</scope>
| } | ||
|
|
||
| public void eval(CompletableFuture<double[]> result, String text, String modelName) { | ||
| public void eval(CompletableFuture<FlinkVectorType> result, String text, String modelName) { |
There was a problem hiding this comment.
Exceptions thrown by openAIEmbeddings.vectorEmbed are not handled; consider using whenComplete or exceptionally on the returned future to complete the result CompletableFuture exceptionally, ensuring errors propagate correctly.
ferenc-csaky
force-pushed
the
return-vector-from-vector-embed
branch
from
5afcb02 to
cd2fe7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of completeness in the current structure this requires a
openai-functionsto depend onvector-type, asFlinkVectorTypeis defined in the latter. That is not a problem, cause both will be part of the uber JAR, hence I incloded it with aprovidedscope.Relevant examples PR: DataSQRL/datasqrl-examples#62
TODO