Improved mechanism of schema and catalog name replacement #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sqlite has no support for multischema so storage nodes won't be built on it, at least for now so it is ok.
- Extractor uses direct calls of Schema name - Translate (..., SchemaNode) uses base translation except for Temporary table - TranslateToString implementation is commented
use DbNames, no actualization on MySql DROP INDEX
+ StorageDriver.Compile(ISqlCompileUnit, NodeConfiguration) marked obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When domain option
ShareSchemaOverNodesis activated,SqlTranslatorno longer usesSqlNodeActualizerto translate schema's and catalog's to string, it puts special placeholder -SchemaNodePlaceholderNode, soPostCompilertranslates it later on, just before getting actual string.