Skip to content

fixes to glossary scrolling #30648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes to glossary scrolling #30648

wants to merge 2 commits into from

Conversation

fitzage
Copy link
Contributor

@fitzage fitzage commented Jul 22, 2025

What does this PR do? What is the motivation?

https://datadoghq.atlassian.net/browse/WEB-5827

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

https://docs-staging.datadoghq.com/fitzage/gallery-scrolling/glossary/

There are a number of search terms you can test, but scope is a useful example. Each of these should result in the glossary page scrolling to the correct spot, unlike the production site.

  1. Search from a different page and select the glossary result
  2. Search when already on the glossary page and select the result
  3. Search when already on the glossary page with a pre-existing hash or without, and select the glossary result
  4. Search in the homepage search field and select the glossary result

@fitzage fitzage requested a review from a team as a code owner July 22, 2025 22:23
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jul 22, 2025
Copy link
Contributor

github-actions bot commented Jul 22, 2025

ℹ️ Documentation Team Review

No documentation team review is required for this pull request.

@fitzage
Copy link
Contributor Author

fitzage commented Jul 22, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 22, 2025

View all feedbacks in Devflow UI.

2025-07-22 22:42:50 UTC ℹ️ Start processing command /merge


2025-07-22 22:42:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-07-23 02:43:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend mergequeue-status: removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant