-
Notifications
You must be signed in to change notification settings - Fork 469
chore(langchain): make langchain runnable lambda test less flaky #15512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(langchain): make langchain runnable lambda test less flaky #15512
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 3 ms. The average import time from base is: 251 ± 3 ms. The import time difference between this PR and base is: -2.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate sabrenner/make-langchain-runnable-text-less-flaky (0902202) with baseline main (cdc72b2) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.6% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ add_inplace_aspectTime: ✅ 0.410µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +3.9% ✅ add_inplace_noaspectTime: ✅ 0.314µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.5% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.9% ✅ add_noaspectTime: ✅ 0.284µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +2.8% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 1.335µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.9% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +4.3% ✅ bytearray_extend_aspectTime: ✅ 1.491µs (SLO: <10.000µs 📉 -85.1%) vs baseline: -1.0% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 0.610µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -1.1% Memory: ✅ 40.600MB (SLO: <41.500MB -2.2%) vs baseline: +5.7% ✅ bytearray_noaspectTime: ✅ 0.481µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ bytes_aspectTime: ✅ 1.299µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +2.1% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ bytesio_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.7% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ bytesio_noaspectTime: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.9% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.5% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +3.9% ✅ capitalize_noaspectTime: ✅ 0.440µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.8% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +3.8% ✅ casefold_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.3% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +3.8% ✅ casefold_noaspectTime: ✅ 0.374µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.0% Memory: ✅ 40.423MB (SLO: <41.500MB -2.6%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.4% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ encode_aspectTime: ✅ 0.706µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.6% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.6% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ format_aspectTime: ✅ 3.423µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.6% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.1% ✅ format_map_aspectTime: ✅ 3.508µs (SLO: <10.000µs 📉 -64.9%) vs baseline: -1.4% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +3.6% ✅ format_map_noaspectTime: ✅ 0.775µs (SLO: <10.000µs 📉 -92.3%) vs baseline: +0.4% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.1% ✅ format_noaspectTime: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.3% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.5%) vs baseline: +0.2% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.5% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.0% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.606µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +1.8% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ ljust_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.1% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.285µs (SLO: <10.000µs 📉 -77.2%) vs baseline: +1.4% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.2% ✅ lower_noaspectTime: ✅ 0.364µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.9% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.250µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +0.3% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.1% Memory: ✅ 40.364MB (SLO: <41.500MB -2.7%) vs baseline: +5.3% ✅ modulo_aspectTime: ✅ 1.037µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +3.2% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.536µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -1.7% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.2% ✅ modulo_aspect_for_bytesTime: ✅ 0.979µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.2% Memory: ✅ 40.442MB (SLO: <41.500MB -2.5%) vs baseline: +5.5% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.285µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +5.5% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ modulo_noaspectTime: ✅ 0.629µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.3% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 4.886µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -1.1% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +1.1% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.9% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.4% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +5.3% ✅ rstrip_aspectTime: ✅ 2.056µs (SLO: <20.000µs 📉 -89.7%) vs baseline: +6.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.1% ✅ rstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.6% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.449µs (SLO: <10.000µs 📉 -95.5%) vs baseline: ~same Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ stringio_aspectTime: ✅ 1.553µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.9% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ stringio_noaspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.3% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.223µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.4% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +5.1% ✅ swapcase_aspectTime: ✅ 2.504µs (SLO: <10.000µs 📉 -75.0%) vs baseline: +2.3% Memory: ✅ 40.029MB (SLO: <41.500MB -3.5%) vs baseline: +4.0% ✅ swapcase_noaspectTime: ✅ 0.539µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.2% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 2.653µs (SLO: <10.000µs 📉 -73.5%) vs baseline: 📈 +10.9% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.5% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ translate_aspectTime: ✅ 3.316µs (SLO: <10.000µs 📉 -66.8%) vs baseline: -0.1% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +3.7% ✅ upper_aspectTime: ✅ 2.321µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +3.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.8% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.163µs (SLO: <10.000µs 📉 -48.4%) vs baseline: 📈 +25.1% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.096µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +0.9% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 6.134µs (SLO: <10.000µs 📉 -38.7%) vs baseline: -0.8% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 2.282µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.3% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.4% ✅ ospathnormcase_aspectTime: ✅ 3.417µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.4% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.3% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.4% ✅ ospathsplit_aspectTime: ✅ 4.780µs (SLO: <10.000µs 📉 -52.2%) vs baseline: +1.1% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.586µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.6% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.678µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.3% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.1% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.511µs (SLO: <10.000µs 📉 -54.9%) vs baseline: -0.5% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.390µs (SLO: <10.000µs 📉 -86.1%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.394µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +15.6% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.5% ✅ 1-count-metrics-100-timesTime: ✅ 200.703µs (SLO: <220.000µs -8.8%) vs baseline: ~same Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.270µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.000µs (SLO: <230.000µs -6.5%) vs baseline: -0.5% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.5% ✅ 1-gauge-metric-1-timesTime: ✅ 2.160µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.2% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.5% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.875µs (SLO: <150.000µs -9.4%) vs baseline: -0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.3% ✅ 1-rate-metric-1-timesTime: ✅ 3.072µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +0.4% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 213.108µs (SLO: <250.000µs 📉 -14.8%) vs baseline: -1.5% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.428ms (SLO: <22.000ms -7.1%) vs baseline: +0.7% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.317ms (SLO: <2.550ms -9.1%) vs baseline: +1.7% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.2%) vs baseline: +0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.209ms (SLO: <2.550ms 📉 -13.4%) vs baseline: +0.7% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.632µs (SLO: <20.000µs 📉 -76.8%) vs baseline: -1.0% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 175.242µs (SLO: <250.000µs 📉 -29.9%) vs baseline: -0.5% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.191ms (SLO: <2.500ms 📉 -12.4%) vs baseline: +0.1% Memory: ✅ 35.960MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +5.1% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
One of the tests added in #15477 asserts a list of span links, but since we only care about content and not order, asserting the raw lists sometimes flaked if the list was out of order (which doesn't matter for span links). so instead, since we cannot hash them into a set because they're dicts, we assert one expected element at a time.
Testing
updating the test itself, will check on the health of it after it merges
Risks
none, passed still locally