-
Notifications
You must be signed in to change notification settings - Fork 469
fix(graphql): emit span exception event #15480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We make the GraphQL integration emit span exception events for the other products that rely on exception information being attached to spans.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 245 ± 2 ms. The average import time from base is: 247 ± 1 ms. The import time difference between this PR and base is: -2.42 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate fix/graphql-emit-span-exception-event (646facc) with baseline main (7403848) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.120µs (SLO: <10.000µs 📉 -48.8%) vs baseline: 📈 +22.7% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.071µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -0.9% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathjoin_aspectTime: ✅ 6.170µs (SLO: <10.000µs 📉 -38.3%) vs baseline: -0.3% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.3% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.6% ✅ ospathnormcase_aspectTime: ✅ 3.433µs (SLO: <10.000µs 📉 -65.7%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.5% ✅ ospathnormcase_noaspectTime: ✅ 0.564µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -2.1% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.734µs (SLO: <10.000µs 📉 -52.7%) vs baseline: -0.6% Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.3% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.5% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.631µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -0.7% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.699µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.3% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.504µs (SLO: <10.000µs 📉 -55.0%) vs baseline: -0.7% Memory: ✅ 40.029MB (SLO: <41.000MB -2.4%) vs baseline: +4.5% ✅ ospathsplitext_noaspectTime: ✅ 1.369µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.9% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.374µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +15.3% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 200.739µs (SLO: <220.000µs -8.8%) vs baseline: ~same Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.279µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -1.1% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.152µs (SLO: <230.000µs -5.2%) vs baseline: -0.7% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.152µs (SLO: <20.000µs 📉 -89.2%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.855µs (SLO: <150.000µs -9.4%) vs baseline: -0.3% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.5% ✅ 1-rate-metric-1-timesTime: ✅ 3.056µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.6% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 1-rate-metrics-100-timesTime: ✅ 213.365µs (SLO: <250.000µs 📉 -14.7%) vs baseline: -2.0% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.565ms (SLO: <22.000ms -6.5%) vs baseline: +2.0% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.263ms (SLO: <2.300ms 🟡 -1.6%) vs baseline: -1.4% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.1%) vs baseline: +0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.209ms (SLO: <2.550ms 📉 -13.4%) vs baseline: +0.2% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.548µs (SLO: <20.000µs 📉 -77.3%) vs baseline: +0.1% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 172.895µs (SLO: <250.000µs 📉 -30.8%) vs baseline: -0.5% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.180ms (SLO: <2.500ms 📉 -12.8%) vs baseline: -0.7% Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +4.9% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
quinna-h
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking but is there an updated snapshot file / something to reflect the changes?
Description
We make the GraphQL integration emit span exception events for the other products that rely on exception information being attached to spans.