-
Notifications
You must be signed in to change notification settings - Fork 469
chore(writer): move forksafe hooks to writer #15458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 255 ± 3 ms. The average import time from base is: 257 ± 3 ms. The import time difference between this PR and base is: -2.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate vianney/fix-llmobs-flakyness (2fe9e3c) with baseline main (701a90d) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 3.347µs (SLO: <20.000µs 📉 -83.3%) vs baseline: 📈 +14.9% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 203.443µs (SLO: <220.000µs -7.5%) vs baseline: +0.8% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.276µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -0.9% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.508µs (SLO: <230.000µs -5.9%) vs baseline: -0.4% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.158µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.9% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.615µs (SLO: <150.000µs -8.9%) vs baseline: +0.6% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.055µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -1.0% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +4.3% ✅ 1-rate-metrics-100-timesTime: ✅ 215.307µs (SLO: <250.000µs 📉 -13.9%) vs baseline: -0.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.3% ✅ 100-count-metrics-100-timesTime: ✅ 20.282ms (SLO: <22.000ms -7.8%) vs baseline: +0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ❌ 100-distribution-metrics-100-timesTime: ❌ 2.313ms (SLO: <2.300ms +0.6%) vs baseline: +1.9% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.413ms (SLO: <1.550ms -8.9%) vs baseline: +0.7% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.5% ✅ 100-rate-metrics-100-timesTime: ✅ 2.231ms (SLO: <2.550ms 📉 -12.5%) vs baseline: -0.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.546µs (SLO: <20.000µs 📉 -77.3%) vs baseline: ~same Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.263µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.9% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.185ms (SLO: <2.500ms 📉 -12.6%) vs baseline: -0.8% Memory: ✅ 35.881MB (SLO: <36.500MB 🟡 -1.7%) vs baseline: +4.7% 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.128µs (SLO: <10.000µs 📉 -48.7%) vs baseline: 📈 +25.3% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.086µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.1% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.129µs (SLO: <10.000µs 📉 -38.7%) vs baseline: -0.8% Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.406µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -1.1% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 0.563µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.5% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.5% ✅ ospathsplit_aspectTime: ✅ 4.686µs (SLO: <10.000µs 📉 -53.1%) vs baseline: -1.2% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.587µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -1.0% Memory: ✅ 40.069MB (SLO: <41.000MB -2.3%) vs baseline: +4.5% ✅ ospathsplitdrive_aspectTime: ✅ 3.606µs (SLO: <10.000µs 📉 -63.9%) vs baseline: -0.9% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.696µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -1.6% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.5% ✅ ospathsplitext_aspectTime: ✅ 4.492µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -0.2% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.6% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
de4348a to
b634edd
Compare
68c0c25 to
22519a3
Compare
Description
Move forksafe hooks to the writer following what's done in the LLMObs service.
This requires
stop_serviceto always be called before dropping the writer as the hooks will prevent the writer from being dropped.Testing
Risks
Additional Notes