Backport gyuheon0h/prof-12661-runtime-stacks to 3.19.0
#15440
+10,186
−2,326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the IAST CI, it is working but some tests looks flaky: ``` FLAKY tests/appsec/iast/taint_tracking/test_native_taint_range.py::test_context_race_conditions_threads[py3.10] FLAKY tests/appsec/iast/test_overhead_control_engine.py::test_oce_max_vulnerabilities_per_request[py3.10] FLAKY tests/appsec/iast/test_overhead_control_engine.py::test_oce_reset_vulnerabilities_report[py3.10] FLAKY tests/appsec/iast/test_telemetry.py::test_log_metric[py3.10] FLAKY tests/appsec/iast/test_telemetry.py::test_log_metric_debug_deduplication[py3.10] FLAKY tests/appsec/iast/test_telemetry.py::test_log_metric_debug_deduplication_different_messages[py3.10] ```
## Description <!-- Provide an overview of the change and motivation for the change --> Bump libdatadog to v24.0.0 ## Testing <!-- Describe your testing strategy or note what tests are included --> Checked that native module compiles. ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Alberto Vara <[email protected]> Co-authored-by: Gyuheon Oh <[email protected]>
Reopening #15098 as it was accidentally merged too early. ## Description <!-- Provide an overview of the change and motivation for the change --> Integrate datadog-ffe from libdatadog: DataDog/libdatadog#1289 ## Testing <!-- Describe your testing strategy or note what tests are included --> Tested manually that native bindings work: ``` >>> from ddtrace.internal.native._native import ffe >>> with open("/Users/oleksii.shmalko/dd/libdatadog/datadog-ffe/tests/data/flags-v1.json", 'rb') as f: ... json = f.read() ... >>> config = ffe.Configuration(json) >>> details = config.resolve_value("numeric_flag", ffe.FlagType.Float, {}) >>> details.variant 'pi' >>> details.value 3.1415926 ``` More testing will be done as part of FFE feature. ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> This PR is stacked against #15219 --------- Co-authored-by: Alberto Vara <[email protected]>
## Description Enables the native writer by default. The native writer can still be disabled through _DD_TRACE_WRITER_NATIVE. ## Testing All tests are run with the native writer. The native writer have also been enabled on some services internally for dogfooding purposes. ## Risks This changes the logic behind trace export and client-side stats computation (for customers who enabled it). We expect no change in behavior for trace exporting. Client-side stats behavior may show some differences as the current python implementation is not fully compliant with the client-side stats spec. --------- Co-authored-by: Brett Langdon <[email protected]>
They are failing with: > AttributeError: 'OverheadControl' object has no attribute 'release_request' Which means we aren't getting benchmark results, and now the SLO check will fail if the results for a given benchmark are missing. <!-- Describe your testing strategy or note what tests are included --> <!-- Note any risks associated with this change, or "None" if no risks --> <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Emmett Butler <[email protected]> (cherry picked from commit 52d499b)
…14828) ## Description Adds server info metadata to llm observability mcp client session "root" spans. This information includes - server name - server version - server title Additionally, adds similar tags to client tool spans: - For both client and server tool calls, mark which kind of tool call they are on a tag (as besides the name, which could vary for manual instrumentation, it is not apparent as they are just normal tool calls otherwise) - adds the mcp server name of the session the client tool call was used for Lastly, generally for the `mcp` integration, we now mark client tool calls as errors when the tool result returned from the mcp server was an error as well. MLOB-4147 ## Testing Add unit tests, and additionally, verified through internal testing against a staging hash in our frontend. ## Risks None
## Description backport of #15071 to 3.19 ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Yun Kim <[email protected]>
(cherry picked from commit 838480c) Co-authored-by: Brett Langdon <[email protected]>
GianlucaBortoli
changed the title
gyuheon0h/prof-12661-runtime-stacks to 3.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14765 branched off from
3.19.0tag + #15425Testing
Risks
Additional Notes