-
Notifications
You must be signed in to change notification settings - Fork 468
chore(profiling): improve readability/add comments #15427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(profiling): improve readability/add comments #15427
Conversation
|
|
8778e79 to
e738daa
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 248 ± 3 ms. The average import time from base is: 257 ± 5 ms. The import time difference between this PR and base is: -8.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate kowalski/chore-profiling-improve-readability-add-comments (e738daa) with baseline main (61c07d1) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.939µs (SLO: <10.000µs 📉 -50.6%) vs baseline: 📈 +18.5% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.4% ✅ ospathbasename_noaspectTime: ✅ 1.086µs (SLO: <10.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.181µs (SLO: <10.000µs 📉 -38.2%) vs baseline: +0.2% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.280µs (SLO: <10.000µs 📉 -77.2%) vs baseline: ~same Memory: ✅ 40.383MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.3% ✅ ospathnormcase_aspectTime: ✅ 3.391µs (SLO: <10.000µs 📉 -66.1%) vs baseline: +0.6% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.7% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.793µs (SLO: <10.000µs 📉 -52.1%) vs baseline: +0.8% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.3% ✅ ospathsplit_noaspectTime: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.2% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.2% ✅ ospathsplitdrive_aspectTime: ✅ 3.584µs (SLO: <10.000µs 📉 -64.2%) vs baseline: +0.6% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.702µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.2% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.423µs (SLO: <10.000µs 📉 -55.8%) vs baseline: -2.1% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.385µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.1% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.6% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.457µs (SLO: <20.000µs 📉 -82.7%) vs baseline: 📈 +16.4% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 203.341µs (SLO: <220.000µs -7.6%) vs baseline: +0.8% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.4% ✅ 1-distribution-metric-1-timesTime: ✅ 3.312µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.304µs (SLO: <230.000µs -6.0%) vs baseline: +0.6% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.229µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.7% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 139.643µs (SLO: <150.000µs -6.9%) vs baseline: +1.3% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.134µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +1.3% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.3% ✅ 1-rate-metrics-100-timesTime: ✅ 218.027µs (SLO: <250.000µs 📉 -12.8%) vs baseline: +1.3% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.384ms (SLO: <22.000ms -7.3%) vs baseline: +0.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.4% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.241ms (SLO: <2.300ms -2.5%) vs baseline: -1.0% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.3% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.420ms (SLO: <1.550ms -8.4%) vs baseline: +0.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ 100-rate-metrics-100-timesTime: ✅ 2.219ms (SLO: <2.550ms 📉 -13.0%) vs baseline: +0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.413µs (SLO: <20.000µs 📉 -77.9%) vs baseline: -0.5% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 172.880µs (SLO: <250.000µs 📉 -30.8%) vs baseline: -0.1% Memory: ✅ 35.350MB (SLO: <35.500MB 🟡 -0.4%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.184ms (SLO: <2.500ms 📉 -12.7%) vs baseline: ~same Memory: ✅ 36.117MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +4.8% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes