-
Notifications
You must be signed in to change notification settings - Fork 469
ci: update cython-lint and address errors #15407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 3 ms. The average import time from base is: 252 ± 3 ms. The import time difference between this PR and base is: -2.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate taegyunkim/upgrade-cython-lint (065dbc1) with baseline main (124b19d) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 3.395µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +14.9% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 200.881µs (SLO: <220.000µs -8.7%) vs baseline: -0.5% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.280µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -0.3% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.3% ✅ 1-distribution-metrics-100-timesTime: ✅ 219.007µs (SLO: <230.000µs -4.8%) vs baseline: ~same Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.203µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.1% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.856µs (SLO: <150.000µs -8.1%) vs baseline: -0.9% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.074µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -0.7% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 216.584µs (SLO: <250.000µs 📉 -13.4%) vs baseline: +0.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 100-count-metrics-100-timesTime: ✅ 20.410ms (SLO: <22.000ms -7.2%) vs baseline: -0.6% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.4% ❌ 100-distribution-metrics-100-timesTime: ❌ 2.325ms (SLO: <2.300ms +1.1%) vs baseline: +0.6% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.422ms (SLO: <1.550ms -8.2%) vs baseline: ~same Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.215ms (SLO: <2.550ms 📉 -13.1%) vs baseline: -1.4% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.538µs (SLO: <20.000µs 📉 -77.3%) vs baseline: -0.2% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.688µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.1% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.191ms (SLO: <2.500ms 📉 -12.3%) vs baseline: -0.1% Memory: ✅ 35.940MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.8% 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.162µs (SLO: <10.000µs 📉 -48.4%) vs baseline: 📈 +25.5% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.081µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.8% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.130µs (SLO: <10.000µs 📉 -38.7%) vs baseline: -0.3% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 2.270µs (SLO: <10.000µs 📉 -77.3%) vs baseline: -1.6% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.424µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.2% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.744µs (SLO: <10.000µs 📉 -52.6%) vs baseline: -0.6% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.3% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.650µs (SLO: <10.000µs 📉 -63.5%) vs baseline: ~same Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.497µs (SLO: <10.000µs 📉 -55.0%) vs baseline: +0.2% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.1% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Description
cython-lintused to skip_encoding.pyxforUpdated
_encoding.pyxasTesting
Risks
Additional Notes