-
Notifications
You must be signed in to change notification settings - Fork 468
ci: add setup downloads retries #15398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 252 ± 4 ms. The average import time from base is: 253 ± 4 ms. The import time difference between this PR and base is: -0.5 ± 0.2 ms. The difference is not statistically significant (z = -2.64). Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/setup.retries (0d7c340) with baseline main (97b28b0) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.197µs (SLO: <10.000µs 📉 -48.0%) vs baseline: 📈 +20.0% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.2% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.190µs (SLO: <10.000µs 📉 -38.1%) vs baseline: +1.0% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 2.291µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.7% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.559µs (SLO: <10.000µs 📉 -64.4%) vs baseline: +1.0% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.571µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.2% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 4.857µs (SLO: <10.000µs 📉 -51.4%) vs baseline: -0.6% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.3% ✅ ospathsplit_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.717µs (SLO: <10.000µs 📉 -62.8%) vs baseline: +0.6% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.2% ✅ ospathsplitdrive_noaspectTime: ✅ 0.697µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.7% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ ospathsplitext_aspectTime: ✅ 4.614µs (SLO: <10.000µs 📉 -53.9%) vs baseline: +0.9% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.3% ✅ ospathsplitext_noaspectTime: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.3% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.4% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.440µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +18.1% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 203.303µs (SLO: <220.000µs -7.6%) vs baseline: +1.8% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.291µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.295µs (SLO: <230.000µs -6.4%) vs baseline: +0.8% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.193µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.4% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.244µs (SLO: <150.000µs -9.2%) vs baseline: -0.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.096µs (SLO: <20.000µs 📉 -84.5%) vs baseline: +1.1% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 216.265µs (SLO: <250.000µs 📉 -13.5%) vs baseline: +1.2% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.357ms (SLO: <22.000ms -7.5%) vs baseline: +0.8% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.252ms (SLO: <2.300ms -2.1%) vs baseline: -1.5% Memory: ✅ 35.252MB (SLO: <35.500MB 🟡 -0.7%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: +0.4% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.211ms (SLO: <2.550ms 📉 -13.3%) vs baseline: +0.2% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.483µs (SLO: <20.000µs 📉 -77.6%) vs baseline: +0.5% Memory: ✅ 35.252MB (SLO: <35.500MB 🟡 -0.7%) vs baseline: +5.2% ✅ flush-100-metricsTime: ✅ 173.184µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.2% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.190ms (SLO: <2.500ms 📉 -12.4%) vs baseline: -0.2% Memory: ✅ 36.078MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.7% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
| FetchContent_Declare( | ||
| absl | ||
| URL "https://github.com/abseil/abseil-cpp/archive/refs/tags/20250127.1.zip" | ||
| TIMEOUT 600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 600 is too much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non blocking nit
Description
with 10 retries and configurable delays
DD_DOWNLOAD_MAX_DELAY environment variables
Testing
Risks
Additional Notes