-
Notifications
You must be signed in to change notification settings - Fork 469
fix(ci_visibility): do not fetch tags while unshallowing git repo [backport 3.18] #15154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…5133) Backport aeb5df4 from #15133 to 3.17. Currently when calling `git fetch` to unshallow a repo, we end up fetching repo tags, even though we don't need them. This can have a performance impact in repos with a large number of tags. This PR changes it to call `git fetch` with `--no-tags`. Unit tests and manual testing. None. None.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 243 ± 6 ms. The average import time from base is: 247 ± 6 ms. The import time difference between this PR and base is: -3.9 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-15133-to-3.18 (2fab6d6) with baseline 3.18 (635be97) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 2.993µs (SLO: <20.000µs 📉 -85.0%) vs baseline: +1.2% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 208.352µs (SLO: <220.000µs -5.3%) vs baseline: +5.5% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.316µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +2.2% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ❌ 1-distribution-metrics-100-timesTime: ❌ 221.864µs (SLO: <220.000µs +0.8%) vs baseline: +4.4% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.513µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +15.1% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.736µs (SLO: <150.000µs -9.5%) vs baseline: -1.2% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.552µs (SLO: <20.000µs 📉 -82.2%) vs baseline: 📈 +15.1% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 216.564µs (SLO: <250.000µs 📉 -13.4%) vs baseline: +2.7% Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 21.163ms (SLO: <22.000ms -3.8%) vs baseline: +5.3% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.266ms (SLO: <2.300ms 🟡 -1.5%) vs baseline: +2.1% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.420ms (SLO: <1.550ms -8.4%) vs baseline: +1.0% Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.326ms (SLO: <2.550ms -8.8%) vs baseline: +6.8% Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +4.5% ✅ flush-1-metricTime: ✅ 4.867µs (SLO: <20.000µs 📉 -75.7%) vs baseline: +5.1% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 174.770µs (SLO: <250.000µs 📉 -30.1%) vs baseline: +0.1% Memory: ✅ 31.850MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.122ms (SLO: <2.500ms 📉 -15.1%) vs baseline: +0.5% Memory: ✅ 32.637MB (SLO: <34.500MB -5.4%) vs baseline: +4.8% 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.222µs (SLO: <10.000µs 📉 -57.8%) vs baseline: -0.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.095µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.1% Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.256µs (SLO: <10.000µs 📉 -37.4%) vs baseline: +2.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.273µs (SLO: <10.000µs 📉 -77.3%) vs baseline: -1.4% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.469µs (SLO: <10.000µs 📉 -65.3%) vs baseline: -1.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.5% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 5.883µs (SLO: <10.000µs 📉 -41.2%) vs baseline: 📈 +21.8% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.587µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -1.0% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.727µs (SLO: <10.000µs 📉 -62.7%) vs baseline: ~same Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.695µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.2% Memory: ✅ 37.356MB (SLO: <39.000MB -4.2%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 5.346µs (SLO: <10.000µs 📉 -46.5%) vs baseline: 📈 +17.2% Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +4.9% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.482ms (SLO: <22.300ms -8.2%) vs baseline: +0.1% Memory: ✅ 66.001MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.342ms (SLO: <1.450ms -7.5%) vs baseline: -0.4% Memory: ✅ 64.155MB (SLO: <67.000MB -4.2%) vs baseline: +4.7% ✅ iastTime: ✅ 20.456ms (SLO: <22.250ms -8.1%) vs baseline: -0.3% Memory: ✅ 66.033MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.456ms (SLO: <16.550ms -6.6%) vs baseline: -0.5% Memory: ✅ 53.839MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.534ms (SLO: <21.750ms -5.6%) vs baseline: ~same Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.397ms (SLO: <28.200ms -9.9%) vs baseline: -0.2% Memory: ✅ 67.029MB (SLO: <69.500MB -3.6%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.510ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.669ms (SLO: <23.500ms -3.5%) vs baseline: -0.2% Memory: ✅ 67.504MB (SLO: <68.000MB 🟡 -0.7%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.299ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.4% Memory: ✅ 66.041MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.611ms (SLO: <17.500ms -5.1%) vs baseline: -0.1% Memory: ✅ 65.874MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.469ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 67.476MB (SLO: <72.500MB -6.9%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.489ms (SLO: <19.650ms -5.9%) vs baseline: -0.2% Memory: ✅ 66.021MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.770ms (SLO: <20.100ms -6.6%) vs baseline: -0.2% Memory: ✅ 65.706MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.200ms (SLO: <21.500ms -6.0%) vs baseline: +0.2% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.326ms (SLO: <22.000ms -7.6%) vs baseline: +0.2% Memory: ✅ 66.080MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.081ms (SLO: <19.850ms -8.9%) vs baseline: +0.2% Memory: ✅ 65.942MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.051ms (SLO: <19.400ms -7.0%) vs baseline: +0.1% Memory: ✅ 65.962MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +4.5% ✅ tracer-enabledTime: ✅ 18.231ms (SLO: <19.450ms -6.3%) vs baseline: +0.5% Memory: ✅ 65.588MB (SLO: <66.500MB 🟡 -1.4%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.084ms (SLO: <2.300ms -9.4%) vs baseline: +1.0% Memory: ✅ 52.494MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +5.4% ✅ errortracking-enabled-userTime: ✅ 2.074ms (SLO: <2.250ms -7.8%) vs baseline: +0.7% Memory: ✅ 52.455MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.088ms (SLO: <2.300ms -9.2%) vs baseline: +1.2% Memory: ✅ 52.534MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 62.195MB (SLO: <65.000MB -4.3%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.612ms (SLO: <6.750ms -2.0%) vs baseline: +0.1% Memory: ✅ 62.232MB (SLO: <65.000MB -4.3%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 62.186MB (SLO: <65.000MB -4.3%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: +0.3% Memory: ✅ 45.296MB (SLO: <47.000MB -3.6%) vs baseline: +5.1% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 41.978MB (SLO: <49.000MB 📉 -14.3%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: +0.2% Memory: ✅ 46.456MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 52.561MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 52.540MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: +0.1% Memory: ✅ 54.011MB (SLO: <60.000MB -10.0%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.962ms (SLO: <4.200ms -5.7%) vs baseline: ~same Memory: ✅ 62.226MB (SLO: <66.000MB -5.7%) vs baseline: +4.8% ✅ iast-enabledTime: ✅ 2.455ms (SLO: <2.800ms 📉 -12.3%) vs baseline: +0.8% Memory: ✅ 59.199MB (SLO: <60.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.054ms (SLO: <2.250ms -8.7%) vs baseline: +0.1% Memory: ✅ 52.455MB (SLO: <54.500MB -3.8%) vs baseline: +4.9% 🟡 packagespackageforrootmodulemapping - 4/4✅ cache_offTime: ✅ 347.293ms (SLO: <354.300ms 🟡 -2.0%) vs baseline: +0.5% Memory: ✅ 38.220MB (SLO: <40.000MB -4.4%) vs baseline: +3.8% ✅ cache_onTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.1% Memory: ✅ 37.061MB (SLO: <39.000MB -5.0%) vs baseline: +4.5%
|
Backport aeb5df4 from #15133 to 3.18.
Description
Currently when calling
git fetchto unshallow a repo, we end up fetching repo tags, even though we don't need them. This can have a performance impact in repos with a large number of tags. This PR changes it to callgit fetchwith--no-tags.Testing
Unit tests and manual testing.
Risks
None.
Additional Notes
None.