fix: modify error tracking exceptions #15148
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 237 ± 3 ms. The average import time from base is: 240 ± 2 ms. The import time difference between this PR and base is: -3.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate quinna/modify-error-tracking (2c25124) with baseline main (59f52c2) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.247µs (SLO: <10.000µs 📉 -47.5%) vs baseline: 📈 +22.0% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 1.098µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +1.6% Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.483µs (SLO: <10.000µs 📉 -35.2%) vs baseline: +4.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.319µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +0.4% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.518µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +0.5% Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.585µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +3.0% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 5.749µs (SLO: <10.000µs 📉 -42.5%) vs baseline: 📈 +18.8% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.610µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.2% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.704µs (SLO: <10.000µs 📉 -63.0%) vs baseline: ~same Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +4.4% ✅ ospathsplitdrive_noaspectTime: ✅ 0.707µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +1.0% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.565µs (SLO: <10.000µs 📉 -54.4%) vs baseline: -1.0% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.388µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.1% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.469ms (SLO: <22.300ms -8.2%) vs baseline: +0.2% Memory: ✅ 66.208MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: +0.4% Memory: ✅ 64.313MB (SLO: <67.000MB -4.0%) vs baseline: +4.8% ✅ iastTime: ✅ 20.435ms (SLO: <22.250ms -8.2%) vs baseline: -0.2% Memory: ✅ 66.188MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.541ms (SLO: <16.550ms -6.1%) vs baseline: +0.4% Memory: ✅ 53.977MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.495ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 66.139MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.319ms (SLO: <28.200ms 📉 -10.2%) vs baseline: -0.5% Memory: ✅ 67.316MB (SLO: <69.500MB -3.1%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.458ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 66.129MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.637ms (SLO: <23.500ms -3.7%) vs baseline: ~same Memory: ✅ 67.712MB (SLO: <68.000MB 🟡 -0.4%) vs baseline: +4.5% ✅ tracer-dont-create-db-spansTime: ✅ 19.325ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 66.217MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-minimalTime: ✅ 16.554ms (SLO: <17.500ms -5.4%) vs baseline: -0.5% Memory: ✅ 65.903MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 20.512ms (SLO: <21.750ms -5.7%) vs baseline: +0.4% Memory: ✅ 67.672MB (SLO: <72.500MB -6.7%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.480ms (SLO: <19.650ms -6.0%) vs baseline: +0.1% Memory: ✅ 66.170MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.774ms (SLO: <20.100ms -6.6%) vs baseline: +0.3% Memory: ✅ 65.932MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.146ms (SLO: <21.500ms -6.3%) vs baseline: +0.2% Memory: ✅ 66.217MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-no-templatesTime: ✅ 20.306ms (SLO: <22.000ms -7.7%) vs baseline: ~same Memory: ✅ 66.188MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.129ms (SLO: <19.850ms -8.7%) vs baseline: +0.3% Memory: ✅ 66.011MB (SLO: <66.500MB 🟡 -0.7%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.329ms (SLO: <19.400ms -5.5%) vs baseline: +1.5% Memory: ✅ 66.109MB (SLO: <66.500MB 🟡 -0.6%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.210ms (SLO: <19.450ms -6.4%) vs baseline: +0.8% Memory: ✅ 65.855MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.083ms (SLO: <2.300ms -9.4%) vs baseline: +0.9% Memory: ✅ 52.691MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 2.072ms (SLO: <2.250ms -7.9%) vs baseline: -0.1% Memory: ✅ 52.671MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 2.072ms (SLO: <2.300ms -9.9%) vs baseline: ~same Memory: ✅ 52.652MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.596ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 62.295MB (SLO: <65.000MB -4.2%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.623ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.3% Memory: ✅ 62.369MB (SLO: <65.000MB -4.0%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.586ms (SLO: <4.750ms -3.4%) vs baseline: -0.5% Memory: ✅ 62.331MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.4% Memory: ✅ 45.283MB (SLO: <47.000MB -3.7%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: -0.2% Memory: ✅ 42.111MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.5% ✅ profilerTime: ✅ 1.911ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.565MB (SLO: <47.000MB 🟡 -0.9%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: +0.4% Memory: ✅ 52.642MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: -0.4% Memory: ✅ 52.617MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: -0.3% Memory: ✅ 54.114MB (SLO: <60.000MB -9.8%) vs baseline: +4.9% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.977ms (SLO: <4.200ms -5.3%) vs baseline: +0.3% Memory: ✅ 62.403MB (SLO: <66.000MB -5.4%) vs baseline: +4.8% ✅ iast-enabledTime: ✅ 2.437ms (SLO: <2.800ms 📉 -13.0%) vs baseline: ~same Memory: ✅ 59.238MB (SLO: <60.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.058ms (SLO: <2.250ms -8.5%) vs baseline: -0.3% Memory: ✅ 52.612MB (SLO: <54.500MB -3.5%) vs baseline: +4.8%
|
dubloom
left a comment
dubloom
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix
## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ (cherry picked from commit 84db0e6)
## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ (cherry picked from commit 84db0e6)
## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ (cherry picked from commit 84db0e6)
## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ (cherry picked from commit 84db0e6)
## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Backport 84db0e6 from #15148 to 3.17. ## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Quinna Halim <[email protected]>
Backport 84db0e6 from #15148 to 3.18. ## Description <!-- Provide an overview of the change and motivation for the change --> For [APMS-17683](https://datadoghq.atlassian.net/browse/APMS-17683) customer was having an issue where their custom exception object was unhashable, resulting in a `TypeError` when trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> [APMS-17683]: https://datadoghq.atlassian.net/browse/APMS-17683?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Quinna Halim <[email protected]>
Description
For APMS-17683 customer was having an issue where their custom exception object was unhashable, resulting in a
TypeErrorwhen trying to use the object as a key. This fix changes so that we store the exception object id, not the exception object.Testing
Risks
Additional Notes