Skip to content

Conversation

florentinl
Copy link
Contributor

@florentinl florentinl commented Sep 15, 2025

Description

This PR implements the resource renaming feature specified in RFC-1051. This contains the following changes:

The feature is turned off by default behind the env var: "DD_TRACE_RESOURCE_RENAMING_ENABLED"

APPSEC-58892

Notes

Added the TRACING_CONFIG_NONDEFAULT_3 scenario to the CI. It contains the system tests for this feature.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch from 0768898 to a1a885d Compare September 15, 2025 12:34
Copy link
Contributor

github-actions bot commented Sep 15, 2025

CODEOWNERS have been resolved as:

ddtrace/_trace/processor/resource_renaming.py                           @DataDog/apm-sdk-api-python
releasenotes/notes/feat-resource-renaming-e5911d3975c220e3.yaml         @DataDog/apm-python
tests/tracer/test_resource_renaming.py                                  @DataDog/apm-sdk-api-python
.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/python-guild @DataDog/apm-core-python
benchmarks/bm/flask_utils.py                                            @DataDog/apm-core-python
benchmarks/django_simple/config.yaml                                    @DataDog/apm-core-python
benchmarks/django_simple/scenario.py                                    @DataDog/apm-core-python
benchmarks/errortracking_flask_sqli/scenario.py                         @DataDog/apm-core-python
benchmarks/flask_simple/config.yaml                                     @DataDog/apm-core-python
benchmarks/flask_simple/scenario.py                                     @DataDog/apm-core-python
benchmarks/flask_sqli/scenario.py                                       @DataDog/apm-core-python
ddtrace/_trace/tracer.py                                                @DataDog/apm-sdk-api-python
ddtrace/ext/http.py                                                     @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/internal/processor/stats.py                                     @DataDog/apm-core-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python
tests/utils.py                                                          @DataDog/python-guild

Copy link
Contributor

github-actions bot commented Sep 15, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 5 ms.

The average import time from base is: 273 ± 2 ms.

The import time difference between this PR and base is: 1.8 ± 0.2 ms.

Import time breakdown

The following import paths have appeared:

ddtrace.auto 0.376 ms (0.14%)
ddtrace 0.376 ms (0.14%)
ddtrace.trace 0.376 ms (0.14%)
ddtrace._trace.tracer 0.376 ms (0.14%)
ddtrace._trace.processor.resource_renaming 0.376 ms (0.14%)

The following import paths have grown:

ddtrace.auto 0.271 ms (0.10%)
ddtrace 0.271 ms (0.10%)
ddtrace.trace 0.271 ms (0.10%)
ddtrace._trace.context 0.128 ms (0.05%)

The following import paths have shrunk:

ddtrace.auto 1.874 ms (0.68%)
ddtrace.bootstrap.sitecustomize 1.096 ms (0.40%)
ddtrace.bootstrap.preload 1.096 ms (0.40%)
ddtrace.internal.remoteconfig.client 0.584 ms (0.21%)
ddtrace 0.778 ms (0.28%)
ddtrace.trace 0.112 ms (0.04%)
ddtrace._trace.filters 0.112 ms (0.04%)
ddtrace.internal._unpatched 0.026 ms (0.01%)
json 0.026 ms (0.01%)
json.decoder 0.026 ms (0.01%)
re 0.026 ms (0.01%)
enum 0.026 ms (0.01%)
types 0.026 ms (0.01%)

@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch 2 times, most recently from b0126e8 to cdfa633 Compare September 15, 2025 15:11
@pr-commenter
Copy link

pr-commenter bot commented Sep 15, 2025

Performance SLOs

Comparing candidate florentin.labelle/APPSEC-58892/resource-renaming (dc489a5) with baseline main (7042e95)

🟡 Near SLO Breach (5 suites)
🟡 djangosimple - 26/26

✅ appsec

Time: ✅ 20.476ms (SLO: <22.300ms -8.2%) vs baseline: -0.3%

Memory: ✅ 64.464MB (SLO: <66.000MB -2.3%) vs baseline: +4.9%


✅ exception-replay-enabled

Time: ✅ 1.350ms (SLO: <1.450ms -6.9%) vs baseline: +0.1%

Memory: ✅ 63.696MB (SLO: <66.000MB -3.5%) vs baseline: +5.2%


✅ iast

Time: ✅ 20.486ms (SLO: <22.250ms -7.9%) vs baseline: ~same

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +5.0%


✅ profiler

Time: ✅ 15.311ms (SLO: <16.550ms -7.5%) vs baseline: +0.7%

Memory: ✅ 52.999MB (SLO: <53.500MB 🟡 -0.9%) vs baseline: +5.0%


✅ span-code-origin

Time: ✅ 26.110ms (SLO: <28.200ms -7.4%) vs baseline: ~same

Memory: ✅ 66.854MB (SLO: <68.500MB -2.4%) vs baseline: +5.2%


✅ tracer

Time: ✅ 20.537ms (SLO: <21.750ms -5.6%) vs baseline: +0.2%

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +5.0%


✅ tracer-and-profiler

Time: ✅ 22.131ms (SLO: <23.500ms -5.8%) vs baseline: +0.3%

Memory: ✅ 65.857MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +5.0%


✅ tracer-dont-create-db-spans

Time: ✅ 19.289ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.3%

Memory: ✅ 64.527MB (SLO: <66.000MB -2.2%) vs baseline: +5.1%


✅ tracer-native

Time: ✅ 20.503ms (SLO: <21.750ms -5.7%) vs baseline: ~same

Memory: ✅ 65.726MB (SLO: <66.000MB 🟡 -0.4%) vs baseline: +5.1%


✅ tracer-no-caches

Time: ✅ 18.462ms (SLO: <19.650ms -6.0%) vs baseline: ~same

Memory: ✅ 64.468MB (SLO: <66.000MB -2.3%) vs baseline: +4.8%


✅ tracer-no-databases

Time: ✅ 18.805ms (SLO: <20.100ms -6.4%) vs baseline: +0.4%

Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%) vs baseline: +5.0%


✅ tracer-no-middleware

Time: ✅ 20.240ms (SLO: <21.500ms -5.9%) vs baseline: +0.3%

Memory: ✅ 64.487MB (SLO: <66.000MB -2.3%) vs baseline: +4.9%


✅ tracer-no-templates

Time: ✅ 20.325ms (SLO: <22.000ms -7.6%) vs baseline: ~same

Memory: ✅ 64.507MB (SLO: <66.000MB -2.3%) vs baseline: +5.0%


🟡 errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.052ms (SLO: <19.850ms -9.1%) vs baseline: +0.1%

Memory: ✅ 64.468MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +5.0%


✅ errortracking-enabled-user

Time: ✅ 18.125ms (SLO: <19.400ms -6.6%) vs baseline: +0.3%

Memory: ✅ 64.507MB (SLO: <65.500MB 🟡 -1.5%) vs baseline: +5.0%


✅ tracer-enabled

Time: ✅ 18.107ms (SLO: <19.450ms -6.9%) vs baseline: +0.4%

Memory: ✅ 64.444MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +5.0%


🟡 flasksimple - 17/17

✅ appsec-get

Time: ✅ 4.588ms (SLO: <4.750ms -3.4%) vs baseline: +0.2%

Memory: ✅ 62.325MB (SLO: <64.500MB -3.4%) vs baseline: +4.9%


✅ appsec-post

Time: ✅ 6.590ms (SLO: <6.750ms -2.4%) vs baseline: +0.3%

Memory: ✅ 62.364MB (SLO: <64.500MB -3.3%) vs baseline: +5.0%


✅ appsec-telemetry

Time: ✅ 4.574ms (SLO: <4.750ms -3.7%) vs baseline: -0.4%

Memory: ✅ 62.384MB (SLO: <64.500MB -3.3%) vs baseline: +5.0%


✅ debugger

Time: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same

Memory: ✅ 44.709MB (SLO: <45.000MB 🟡 -0.6%) vs baseline: +5.1%


✅ iast-get

Time: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: +0.2%

Memory: ✅ 41.760MB (SLO: <49.000MB 📉 -14.8%) vs baseline: +5.2%


✅ profiler

Time: ✅ 1.917ms (SLO: <2.100ms -8.7%) vs baseline: ~same

Memory: ✅ 44.551MB (SLO: <46.500MB -4.2%) vs baseline: +5.3%


✅ tracer

Time: ✅ 3.378ms (SLO: <3.650ms -7.5%) vs baseline: +0.3%

Memory: ✅ 51.433MB (SLO: <53.500MB -3.9%) vs baseline: +4.8%


✅ tracer-native

Time: ✅ 3.374ms (SLO: <3.650ms -7.6%) vs baseline: +0.2%

Memory: ✅ 52.691MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.0%


🟡 flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.942ms (SLO: <4.200ms -6.1%) vs baseline: +0.4%

Memory: ✅ 62.618MB (SLO: <66.000MB -5.1%) vs baseline: +5.0%


✅ iast-enabled

Time: ✅ 2.451ms (SLO: <2.800ms 📉 -12.5%) vs baseline: -0.6%

Memory: ✅ 58.191MB (SLO: <59.000MB 🟡 -1.4%) vs baseline: +4.9%


✅ tracer-enabled

Time: ✅ 2.078ms (SLO: <2.250ms -7.7%) vs baseline: -0.2%

Memory: ✅ 51.234MB (SLO: <53.500MB -4.2%) vs baseline: +5.0%


🟡 otelspan - 22/22

✅ add-event

Time: ✅ 46.005ms (SLO: <47.150ms -2.4%) vs baseline: +1.7%

Memory: ✅ 44.704MB (SLO: <46.500MB -3.9%) vs baseline: +5.4%


✅ add-metrics

Time: ✅ 320.341ms (SLO: <344.800ms -7.1%) vs baseline: -0.7%

Memory: ✅ 553.767MB (SLO: <562.000MB 🟡 -1.5%) vs baseline: +5.0%


✅ add-tags

Time: ✅ 292.738ms (SLO: <314.000ms -6.8%) vs baseline: +1.3%

Memory: ✅ 554.090MB (SLO: <563.500MB 🟡 -1.7%) vs baseline: +4.9%


✅ get-context

Time: ✅ 82.624ms (SLO: <92.350ms 📉 -10.5%) vs baseline: -0.2%

Memory: ✅ 39.770MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +5.4%


✅ is-recording

Time: ✅ 42.814ms (SLO: <44.500ms -3.8%) vs baseline: -0.9%

Memory: ✅ 44.080MB (SLO: <46.500MB -5.2%) vs baseline: +5.1%


✅ record-exception

Time: ✅ 61.930ms (SLO: <67.650ms -8.5%) vs baseline: +0.5%

Memory: ✅ 40.113MB (SLO: <46.500MB 📉 -13.7%) vs baseline: +5.3%


✅ set-status

Time: ✅ 48.854ms (SLO: <50.400ms -3.1%) vs baseline: -0.3%

Memory: ✅ 44.082MB (SLO: <46.500MB -5.2%) vs baseline: +5.2%


✅ start

Time: ✅ 42.240ms (SLO: <43.450ms -2.8%) vs baseline: +0.2%

Memory: ✅ 44.125MB (SLO: <46.500MB -5.1%) vs baseline: +5.5%


✅ start-finish

Time: ✅ 84.374ms (SLO: <88.000ms -4.1%) vs baseline: +1.3%

Memory: ✅ 34.053MB (SLO: <46.500MB 📉 -26.8%) vs baseline: +5.7%


✅ start-finish-telemetry

Time: ✅ 84.918ms (SLO: <89.000ms -4.6%) vs baseline: ~same

Memory: ✅ 34.013MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +5.5%


✅ update-name

Time: ✅ 44.143ms (SLO: <45.150ms -2.2%) vs baseline: -0.5%

Memory: ✅ 44.351MB (SLO: <46.500MB -4.6%) vs baseline: +5.4%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 12/12 (2 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.444µs (SLO: <20.000µs 📉 -32.8%) vs baseline: +0.5%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.6%


✅ context_with_data_no_listeners

Time: ✅ 3.414µs (SLO: <10.000µs 📉 -65.9%) vs baseline: +0.9%

Memory: ✅ 31.398MB (SLO: <33.500MB -6.3%) vs baseline: +5.0%


⚠️ context_with_data_only_all_listeners

Time: ⚠️ 13.357µs (SLO: <20.000µs 📉 -33.2%) vs baseline: -0.1%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.6%


✅ get_item_exists

Time: ✅ 0.586µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.1%

Memory: ✅ 31.438MB (SLO: <33.500MB -6.2%) vs baseline: +5.5%


✅ get_item_missing

Time: ✅ 0.641µs (SLO: <10.000µs 📉 -93.6%) vs baseline: -0.2%

Memory: ✅ 31.398MB (SLO: <33.500MB -6.3%) vs baseline: +5.0%


✅ set_item

Time: ✅ 24.282µs (SLO: <30.000µs 📉 -19.1%) vs baseline: +1.0%

Memory: ✅ 31.457MB (SLO: <33.500MB -6.1%) vs baseline: +5.2%

✅ All Tests Passing (18 suites)
errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.089ms (SLO: <2.300ms -9.2%) vs baseline: -0.3%

Memory: ✅ 51.181MB (SLO: <53.500MB -4.3%) vs baseline: +5.0%


✅ errortracking-enabled-user

Time: ✅ 2.099ms (SLO: <2.250ms -6.7%) vs baseline: +0.6%

Memory: ✅ 51.160MB (SLO: <53.500MB -4.4%) vs baseline: +4.9%


✅ tracer-enabled

Time: ✅ 2.112ms (SLO: <2.300ms -8.2%) vs baseline: +0.9%

Memory: ✅ 51.253MB (SLO: <53.500MB -4.2%) vs baseline: +4.9%


httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.965µs (SLO: <100.000µs 📉 -18.0%) vs baseline: +1.6%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.3%


✅ b3_headers

Time: ✅ 14.361µs (SLO: <20.000µs 📉 -28.2%) vs baseline: +0.8%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.2%


✅ b3_single_headers

Time: ✅ 13.606µs (SLO: <20.000µs 📉 -32.0%) vs baseline: +2.6%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.4%


✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 64.518µs (SLO: <80.000µs 📉 -19.4%) vs baseline: +1.5%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 66.759µs (SLO: <80.000µs 📉 -16.6%) vs baseline: +1.1%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%


✅ empty_headers

Time: ✅ 1.607µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +1.1%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.2%


✅ full_t_id_datadog_headers

Time: ✅ 23.179µs (SLO: <30.000µs 📉 -22.7%) vs baseline: +1.8%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ invalid_priority_header

Time: ✅ 6.555µs (SLO: <10.000µs 📉 -34.4%) vs baseline: +0.5%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.1%


✅ invalid_span_id_header

Time: ✅ 6.584µs (SLO: <10.000µs 📉 -34.2%) vs baseline: +1.2%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.2%


✅ invalid_tags_header

Time: ✅ 6.595µs (SLO: <10.000µs 📉 -34.0%) vs baseline: +1.7%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.1%


✅ invalid_trace_id_header

Time: ✅ 6.503µs (SLO: <10.000µs 📉 -35.0%) vs baseline: +0.1%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.2%


✅ large_header_no_matches

Time: ✅ 27.523µs (SLO: <30.000µs -8.3%) vs baseline: -0.7%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.1%


✅ large_valid_headers_all

Time: ✅ 28.622µs (SLO: <40.000µs 📉 -28.4%) vs baseline: +0.3%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ medium_header_no_matches

Time: ✅ 9.815µs (SLO: <20.000µs 📉 -50.9%) vs baseline: -1.0%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.1%


✅ medium_valid_headers_all

Time: ✅ 11.298µs (SLO: <20.000µs 📉 -43.5%) vs baseline: +1.3%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%


✅ none_propagation_style

Time: ✅ 1.687µs (SLO: <10.000µs 📉 -83.1%) vs baseline: -1.3%

Memory: ✅ 31.615MB (SLO: <33.500MB -5.6%) vs baseline: +5.4%


✅ tracecontext_headers

Time: ✅ 34.816µs (SLO: <40.000µs 📉 -13.0%) vs baseline: +1.5%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ valid_headers_all

Time: ✅ 6.540µs (SLO: <10.000µs 📉 -34.6%) vs baseline: +0.4%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +4.9%


✅ valid_headers_basic

Time: ✅ 6.105µs (SLO: <10.000µs 📉 -39.0%) vs baseline: +0.4%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%


✅ wsgi_empty_headers

Time: ✅ 1.596µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.2%

Memory: ✅ 31.556MB (SLO: <33.500MB -5.8%) vs baseline: +5.2%


✅ wsgi_invalid_priority_header

Time: ✅ 6.602µs (SLO: <10.000µs 📉 -34.0%) vs baseline: +0.8%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +4.9%


✅ wsgi_invalid_span_id_header

Time: ✅ 1.600µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.1%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.2%


✅ wsgi_invalid_tags_header

Time: ✅ 6.595µs (SLO: <10.000µs 📉 -34.0%) vs baseline: +1.0%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.3%


✅ wsgi_invalid_trace_id_header

Time: ✅ 6.594µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +0.3%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.4%


✅ wsgi_large_header_no_matches

Time: ✅ 28.695µs (SLO: <40.000µs 📉 -28.3%) vs baseline: ~same

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.4%


✅ wsgi_large_valid_headers_all

Time: ✅ 29.787µs (SLO: <40.000µs 📉 -25.5%) vs baseline: -0.2%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.4%


✅ wsgi_medium_header_no_matches

Time: ✅ 10.125µs (SLO: <20.000µs 📉 -49.4%) vs baseline: -0.3%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%


✅ wsgi_medium_valid_headers_all

Time: ✅ 11.451µs (SLO: <20.000µs 📉 -42.7%) vs baseline: -1.0%

Memory: ✅ 31.575MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ wsgi_valid_headers_all

Time: ✅ 6.589µs (SLO: <10.000µs 📉 -34.1%) vs baseline: +0.4%

Memory: ✅ 31.497MB (SLO: <33.500MB -6.0%) vs baseline: +5.1%


✅ wsgi_valid_headers_basic

Time: ✅ 6.130µs (SLO: <10.000µs 📉 -38.7%) vs baseline: +0.1%

Memory: ✅ 31.477MB (SLO: <33.500MB -6.0%) vs baseline: +5.1%


httppropagationinject - 16/16

✅ ids_only

Time: ✅ 22.784µs (SLO: <30.000µs 📉 -24.1%) vs baseline: +4.2%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +4.9%


✅ with_all

Time: ✅ 29.405µs (SLO: <40.000µs 📉 -26.5%) vs baseline: +1.0%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.0%


✅ with_dd_origin

Time: ✅ 26.504µs (SLO: <30.000µs 📉 -11.7%) vs baseline: +3.2%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%


✅ with_priority_and_origin

Time: ✅ 25.264µs (SLO: <40.000µs 📉 -36.8%) vs baseline: +1.3%

Memory: ✅ 31.595MB (SLO: <33.500MB -5.7%) vs baseline: +5.3%


✅ with_sampling_priority

Time: ✅ 21.930µs (SLO: <30.000µs 📉 -26.9%) vs baseline: +1.2%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.1%


✅ with_tags

Time: ✅ 27.546µs (SLO: <40.000µs 📉 -31.1%) vs baseline: +0.6%

Memory: ✅ 31.536MB (SLO: <33.500MB -5.9%) vs baseline: +5.3%


✅ with_tags_invalid

Time: ✅ 28.946µs (SLO: <40.000µs 📉 -27.6%) vs baseline: +0.7%

Memory: ✅ 31.516MB (SLO: <33.500MB -5.9%) vs baseline: +5.3%


✅ with_tags_max_size

Time: ✅ 28.185µs (SLO: <40.000µs 📉 -29.5%) vs baseline: +1.3%

Memory: ✅ 31.634MB (SLO: <33.500MB -5.6%) vs baseline: +5.6%


iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 32.099µs (SLO: <40.000µs 📉 -19.8%) vs baseline: +1.3%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.4%


✅ re_expand_noaspect

Time: ✅ 28.691µs (SLO: <40.000µs 📉 -28.3%) vs baseline: +1.0%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ re_findall_aspect

Time: ✅ 2.900µs (SLO: <10.000µs 📉 -71.0%) vs baseline: -0.6%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ re_findall_noaspect

Time: ✅ 1.423µs (SLO: <10.000µs 📉 -85.8%) vs baseline: ~same

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.7%


✅ re_finditer_aspect

Time: ✅ 4.500µs (SLO: <10.000µs 📉 -55.0%) vs baseline: +0.5%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ re_finditer_noaspect

Time: ✅ 1.410µs (SLO: <10.000µs 📉 -85.9%) vs baseline: ~same

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ re_fullmatch_aspect

Time: ✅ 2.705µs (SLO: <10.000µs 📉 -73.0%) vs baseline: +2.1%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ re_fullmatch_noaspect

Time: ✅ 1.306µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +0.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ re_group_aspect

Time: ✅ 3.055µs (SLO: <10.000µs 📉 -69.5%) vs baseline: +4.1%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ re_group_noaspect

Time: ✅ 1.608µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ re_groups_aspect

Time: ✅ 3.201µs (SLO: <10.000µs 📉 -68.0%) vs baseline: +4.5%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ re_groups_noaspect

Time: ✅ 1.686µs (SLO: <10.000µs 📉 -83.1%) vs baseline: +0.2%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.3%


✅ re_match_aspect

Time: ✅ 2.781µs (SLO: <10.000µs 📉 -72.2%) vs baseline: +3.4%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ re_match_noaspect

Time: ✅ 1.311µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +1.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ re_search_aspect

Time: ✅ 2.599µs (SLO: <10.000µs 📉 -74.0%) vs baseline: +1.6%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ re_search_noaspect

Time: ✅ 1.191µs (SLO: <10.000µs 📉 -88.1%) vs baseline: -0.7%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ re_sub_aspect

Time: ✅ 3.468µs (SLO: <10.000µs 📉 -65.3%) vs baseline: ~same

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.4%


✅ re_sub_noaspect

Time: ✅ 1.527µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ re_subn_aspect

Time: ✅ 3.718µs (SLO: <10.000µs 📉 -62.8%) vs baseline: +1.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ re_subn_noaspect

Time: ✅ 1.635µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +3.0%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.3%


iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.2%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ add_inplace_aspect

Time: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.9%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ add_inplace_noaspect

Time: ✅ 0.314µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ add_noaspect

Time: ✅ 0.275µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ bytearray_aspect

Time: ✅ 1.346µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.9%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ bytearray_extend_aspect

Time: ✅ 1.533µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +3.7%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ bytearray_extend_noaspect

Time: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.1%


✅ bytearray_noaspect

Time: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.3%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.1%


✅ bytes_aspect

Time: ✅ 1.277µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -0.8%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ bytes_noaspect

Time: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ bytesio_aspect

Time: ✅ 1.317µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -1.7%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ bytesio_noaspect

Time: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ capitalize_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ capitalize_noaspect

Time: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.2%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ casefold_aspect

Time: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.5%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ casefold_noaspect

Time: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.6%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.6%


✅ decode_aspect

Time: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ decode_noaspect

Time: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -2.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ encode_aspect

Time: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ encode_noaspect

Time: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ format_aspect

Time: ✅ 3.523µs (SLO: <10.000µs 📉 -64.8%) vs baseline: +4.2%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ format_map_aspect

Time: ✅ 3.651µs (SLO: <10.000µs 📉 -63.5%) vs baseline: +4.3%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.5%


✅ format_map_noaspect

Time: ✅ 0.771µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ format_noaspect

Time: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ index_aspect

Time: ✅ 0.353µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -1.5%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ index_noaspect

Time: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ join_aspect

Time: ✅ 1.322µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -0.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ join_noaspect

Time: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ ljust_aspect

Time: ✅ 2.808µs (SLO: <20.000µs 📉 -86.0%) vs baseline: +8.8%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ ljust_noaspect

Time: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ lower_aspect

Time: ✅ 2.300µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ lower_noaspect

Time: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ lstrip_aspect

Time: ✅ 2.202µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -2.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ lstrip_noaspect

Time: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ modulo_aspect

Time: ✅ 0.990µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -0.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.613µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +5.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


✅ modulo_aspect_for_bytes

Time: ✅ 0.963µs (SLO: <10.000µs 📉 -90.4%) vs baseline: -1.0%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.2%


✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.215µs (SLO: <10.000µs 📉 -87.8%) vs baseline: +2.2%

Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.6%


✅ modulo_noaspect

Time: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ replace_aspect

Time: ✅ 4.993µs (SLO: <10.000µs 📉 -50.1%) vs baseline: +1.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.3%


✅ replace_noaspect

Time: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ repr_aspect

Time: ✅ 0.911µs (SLO: <10.000µs 📉 -90.9%) vs baseline: ~same

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ repr_noaspect

Time: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.5%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ rstrip_aspect

Time: ✅ 1.947µs (SLO: <20.000µs 📉 -90.3%) vs baseline: ~same

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ rstrip_noaspect

Time: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.1%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ slice_aspect

Time: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3%


✅ slice_noaspect

Time: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.7%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3%


✅ stringio_aspect

Time: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +3.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ stringio_noaspect

Time: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.6%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ strip_aspect

Time: ✅ 2.229µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -1.5%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ strip_noaspect

Time: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ swapcase_aspect

Time: ✅ 2.608µs (SLO: <10.000µs 📉 -73.9%) vs baseline: +4.7%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.5%


✅ swapcase_noaspect

Time: ✅ 0.539µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.5%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ title_aspect

Time: ✅ 2.438µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +0.4%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.1%


✅ title_noaspect

Time: ✅ 0.505µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


✅ translate_aspect

Time: ✅ 3.306µs (SLO: <10.000µs 📉 -66.9%) vs baseline: -2.4%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ translate_noaspect

Time: ✅ 1.037µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.3%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ upper_aspect

Time: ✅ 2.340µs (SLO: <10.000µs 📉 -76.6%) vs baseline: +3.2%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ upper_noaspect

Time: ✅ 0.376µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.5%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.5%


iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.250µs (SLO: <10.000µs 📉 -57.5%) vs baseline: -2.9%

Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.4%


✅ ospathbasename_noaspect

Time: ✅ 1.072µs (SLO: <10.000µs 📉 -89.3%) vs baseline: +0.1%

Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


✅ ospathjoin_aspect

Time: ✅ 6.198µs (SLO: <10.000µs 📉 -38.0%) vs baseline: -2.1%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ ospathjoin_noaspect

Time: ✅ 2.292µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.5%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ ospathnormcase_aspect

Time: ✅ 3.537µs (SLO: <10.000µs 📉 -64.6%) vs baseline: -4.4%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.6%


✅ ospathnormcase_noaspect

Time: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.1%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3%


✅ ospathsplit_aspect

Time: ✅ 4.832µs (SLO: <10.000µs 📉 -51.7%) vs baseline: -2.4%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.3%


✅ ospathsplit_noaspect

Time: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.3%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ ospathsplitdrive_aspect

Time: ✅ 3.744µs (SLO: <10.000µs 📉 -62.6%) vs baseline: -3.3%

Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +5.2%


✅ ospathsplitdrive_noaspect

Time: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.9%

Memory: ✅ 37.434MB (SLO: <39.000MB -4.0%) vs baseline: +5.4%


✅ ospathsplitext_aspect

Time: ✅ 4.588µs (SLO: <10.000µs 📉 -54.1%) vs baseline: -1.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ ospathsplitext_noaspect

Time: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.8%

Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.4%


iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.439µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +1.8%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.4%


✅ rsplit_noaspect

Time: ✅ 0.581µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.8%

Memory: ✅ 37.375MB (SLO: <39.000MB -4.2%) vs baseline: +5.0%


✅ split_aspect

Time: ✅ 1.419µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +1.4%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.2%


✅ split_noaspect

Time: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.3%

Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +5.1%


✅ splitlines_aspect

Time: ✅ 1.439µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +5.6%

Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +5.1%


✅ splitlines_noaspect

Time: ✅ 0.587µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.6%

Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +5.5%


iastpropagation - 8/8

✅ no-propagation

Time: ✅ 49.293µs (SLO: <60.000µs 📉 -17.8%) vs baseline: +1.2%

Memory: ✅ 37.041MB (SLO: <39.000MB -5.0%) vs baseline: +5.1%


✅ propagation_enabled

Time: ✅ 168.874µs (SLO: <190.000µs 📉 -11.1%) vs baseline: +2.3%

Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +5.3%


✅ propagation_enabled_100

Time: ✅ 1.852ms (SLO: <1.900ms -2.5%) vs baseline: +0.5%

Memory: ✅ 37.021MB (SLO: <39.000MB -5.1%) vs baseline: +5.2%


✅ propagation_enabled_1000

Time: ✅ 32.113ms (SLO: <35.550ms -9.7%) vs baseline: +0.5%

Memory: ✅ 37.002MB (SLO: <39.000MB -5.1%) vs baseline: +5.0%


otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.491ms (SLO: <42.000ms -3.6%) vs baseline: -0.4%

Memory: ✅ 34.328MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.5%


✅ add-link

Time: ✅ 36.642ms (SLO: <38.550ms -4.9%) vs baseline: -0.2%

Memory: ✅ 34.229MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +5.2%


✅ add-metrics

Time: ✅ 220.564ms (SLO: <232.000ms -4.9%) vs baseline: +0.2%

Memory: ✅ 34.387MB (SLO: <39.000MB 📉 -11.8%) vs baseline: +5.5%


✅ add-tags

Time: ✅ 212.313ms (SLO: <221.600ms -4.2%) vs baseline: -0.4%

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


✅ get-context

Time: ✅ 29.262ms (SLO: <31.300ms -6.5%) vs baseline: +0.7%

Memory: ✅ 34.328MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


✅ is-recording

Time: ✅ 29.238ms (SLO: <31.000ms -5.7%) vs baseline: +0.1%

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +5.1%


✅ record-exception

Time: ✅ 63.349ms (SLO: <65.850ms -3.8%) vs baseline: -0.3%

Memory: ✅ 34.288MB (SLO: <39.000MB 📉 -12.1%) vs baseline: +5.2%


✅ set-status

Time: ✅ 32.144ms (SLO: <34.150ms -5.9%) vs baseline: +0.3%

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


✅ start

Time: ✅ 28.836ms (SLO: <30.150ms -4.4%) vs baseline: ~same

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


✅ start-finish

Time: ✅ 34.153ms (SLO: <35.350ms -3.4%) vs baseline: -0.3%

Memory: ✅ 34.249MB (SLO: <39.000MB 📉 -12.2%) vs baseline: +5.2%


✅ start-finish-telemetry

Time: ✅ 33.933ms (SLO: <35.450ms -4.3%) vs baseline: ~same

Memory: ✅ 34.328MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


✅ update-name

Time: ✅ 31.243ms (SLO: <33.400ms -6.5%) vs baseline: ~same

Memory: ✅ 34.308MB (SLO: <39.000MB 📉 -12.0%) vs baseline: +5.3%


packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 339.293ms (SLO: <354.300ms -4.2%) vs baseline: -0.6%

Memory: ✅ 37.058MB (SLO: <40.000MB -7.4%) vs baseline: +4.3%


✅ cache_on

Time: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.6%

Memory: ✅ 35.814MB (SLO: <39.000MB -8.2%) vs baseline: +3.1%


packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 155.725µs (SLO: <170.000µs -8.4%) vs baseline: ~same

Memory: ✅ 36.516MB (SLO: <38.500MB -5.2%) vs baseline: +5.8%


✅ import_many_cached

Time: ✅ 120.793µs (SLO: <130.000µs -7.1%) vs baseline: ~same

Memory: ✅ 36.411MB (SLO: <38.500MB -5.4%) vs baseline: +4.9%


✅ import_many_stdlib

Time: ✅ 1.620ms (SLO: <1.750ms -7.4%) vs baseline: +1.2%

Memory: ✅ 36.621MB (SLO: <38.500MB -4.9%) vs baseline: +4.9%


✅ import_many_stdlib_cached

Time: ✅ 0.975ms (SLO: <1.100ms 📉 -11.4%) vs baseline: +0.8%

Memory: ✅ 36.642MB (SLO: <38.500MB -4.8%) vs baseline: +5.7%


✅ import_many_unknown

Time: ✅ 832.559µs (SLO: <890.000µs -6.5%) vs baseline: +0.3%

Memory: ✅ 36.500MB (SLO: <38.500MB -5.2%) vs baseline: +4.9%


✅ import_many_unknown_cached

Time: ✅ 796.372µs (SLO: <870.000µs -8.5%) vs baseline: -1.0%

Memory: ✅ 36.581MB (SLO: <38.500MB -5.0%) vs baseline: +5.0%


✅ import_one

Time: ✅ 19.893µs (SLO: <30.000µs 📉 -33.7%) vs baseline: +0.9%

Memory: ✅ 36.431MB (SLO: <39.000MB -6.6%) vs baseline: +5.2%


✅ import_one_cache

Time: ✅ 6.284µs (SLO: <10.000µs 📉 -37.2%) vs baseline: +0.5%

Memory: ✅ 36.354MB (SLO: <38.500MB -5.6%) vs baseline: +3.3%


✅ import_one_stdlib

Time: ✅ 18.645µs (SLO: <20.000µs -6.8%) vs baseline: -0.5%

Memory: ✅ 36.382MB (SLO: <38.500MB -5.5%) vs baseline: +3.0%


✅ import_one_stdlib_cache

Time: ✅ 6.238µs (SLO: <10.000µs 📉 -37.6%) vs baseline: ~same

Memory: ✅ 36.456MB (SLO: <38.500MB -5.3%) vs baseline: +2.7%


✅ import_one_unknown

Time: ✅ 45.166µs (SLO: <50.000µs -9.7%) vs baseline: ~same

Memory: ✅ 36.432MB (SLO: <38.500MB -5.4%) vs baseline: +4.6%


✅ import_one_unknown_cache

Time: ✅ 6.316µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.2%

Memory: ✅ 36.352MB (SLO: <38.500MB -5.6%) vs baseline: +2.0%


ratelimiter - 12/12

✅ defaults

Time: ✅ 2.346µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.2%

Memory: ✅ 31.123MB (SLO: <34.000MB -8.5%) vs baseline: +5.3%


✅ high_rate_limit

Time: ✅ 2.419µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -0.1%

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%) vs baseline: +5.3%


✅ long_window

Time: ✅ 2.332µs (SLO: <10.000µs 📉 -76.7%) vs baseline: -1.2%

Memory: ✅ 31.084MB (SLO: <34.000MB -8.6%) vs baseline: +5.1%


✅ low_rate_limit

Time: ✅ 2.346µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.4%

Memory: ✅ 31.103MB (SLO: <34.000MB -8.5%) vs baseline: +5.2%


✅ no_rate_limit

Time: ✅ 0.832µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.2%

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%) vs baseline: +5.3%


✅ short_window

Time: ✅ 2.506µs (SLO: <10.000µs 📉 -74.9%) vs baseline: +0.8%

Memory: ✅ 31.064MB (SLO: <34.000MB -8.6%) vs baseline: +5.1%


recursivecomputation - 8/8

✅ deep

Time: ✅ 309.656ms (SLO: <320.950ms -3.5%) vs baseline: +0.3%

Memory: ✅ 32.696MB (SLO: <34.500MB -5.2%) vs baseline: +5.6%


✅ deep-profiled

Time: ✅ 326.766ms (SLO: <359.150ms -9.0%) vs baseline: ~same

Memory: ✅ 35.311MB (SLO: <39.000MB -9.5%) vs baseline: +5.1%


✅ medium

Time: ✅ 7.091ms (SLO: <7.400ms -4.2%) vs baseline: +0.2%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.3%


✅ shallow

Time: ✅ 0.960ms (SLO: <1.050ms -8.6%) vs baseline: +0.6%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%


samplingrules - 8/8

✅ average_match

Time: ✅ 148.083µs (SLO: <290.000µs 📉 -48.9%) vs baseline: +0.4%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.3%


✅ high_match

Time: ✅ 193.393µs (SLO: <480.000µs 📉 -59.7%) vs baseline: -0.1%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.5%


✅ low_match

Time: ✅ 100.220µs (SLO: <120.000µs 📉 -16.5%) vs baseline: +0.8%

Memory: ✅ 632.010MB (SLO: <700.000MB -9.7%) vs baseline: +4.9%


✅ very_low_match

Time: ✅ 2.903ms (SLO: <8.500ms 📉 -65.8%) vs baseline: +0.6%

Memory: ✅ 69.746MB (SLO: <75.000MB -7.0%) vs baseline: +4.9%


sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.680µs (SLO: <20.000µs 📉 -46.6%) vs baseline: +1.2%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +5.2%


✅ all-enabled

Time: ✅ 39.958µs (SLO: <50.000µs 📉 -20.1%) vs baseline: +0.2%

Memory: ✅ 32.421MB (SLO: <34.000MB -4.6%) vs baseline: +5.6%


✅ collectipvariant_exists

Time: ✅ 40.760µs (SLO: <50.000µs 📉 -18.5%) vs baseline: +0.2%

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%) vs baseline: +5.3%


✅ no-collectipvariant

Time: ✅ 40.163µs (SLO: <50.000µs 📉 -19.7%) vs baseline: +0.5%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.2%


✅ no-useragentvariant

Time: ✅ 38.915µs (SLO: <50.000µs 📉 -22.2%) vs baseline: +0.2%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +5.2%


✅ obfuscation-no-query

Time: ✅ 40.722µs (SLO: <50.000µs 📉 -18.6%) vs baseline: +0.3%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.2%


✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.474µs (SLO: <90.000µs 📉 -16.1%) vs baseline: -0.2%

Memory: ✅ 32.362MB (SLO: <34.000MB -4.8%) vs baseline: +5.2%


✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.435µs (SLO: <90.000µs 📉 -15.1%) vs baseline: +0.3%

Memory: ✅ 32.342MB (SLO: <34.000MB -4.9%) vs baseline: +5.4%


✅ obfuscation-send-querystring-disabled

Time: ✅ 154.768µs (SLO: <170.000µs -9.0%) vs baseline: +0.8%

Memory: ✅ 32.322MB (SLO: <34.500MB -6.3%) vs baseline: +5.3%


✅ obfuscation-worst-case-explicit-query

Time: ✅ 148.183µs (SLO: <160.000µs -7.4%) vs baseline: +0.3%

Memory: ✅ 32.362MB (SLO: <34.500MB -6.2%) vs baseline: +5.3%


✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.196µs (SLO: <170.000µs -9.3%) vs baseline: ~same

Memory: ✅ 32.362MB (SLO: <34.500MB -6.2%) vs baseline: +5.4%


✅ useragentvariant_exists_1

Time: ✅ 39.341µs (SLO: <50.000µs 📉 -21.3%) vs baseline: -0.7%

Memory: ✅ 32.362MB (SLO: <34.000MB -4.8%) vs baseline: +5.3%


✅ useragentvariant_exists_2

Time: ✅ 40.557µs (SLO: <50.000µs 📉 -18.9%) vs baseline: -0.2%

Memory: ✅ 32.263MB (SLO: <34.000MB -5.1%) vs baseline: +5.6%


✅ useragentvariant_exists_3

Time: ✅ 40.128µs (SLO: <50.000µs 📉 -19.7%) vs baseline: +0.1%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.8%


✅ useragentvariant_not_exists_1

Time: ✅ 40.034µs (SLO: <50.000µs 📉 -19.9%) vs baseline: +1.7%

Memory: ✅ 32.381MB (SLO: <34.000MB -4.8%) vs baseline: +5.4%


✅ useragentvariant_not_exists_2

Time: ✅ 40.196µs (SLO: <50.000µs 📉 -19.6%) vs baseline: +1.4%

Memory: ✅ 32.322MB (SLO: <34.000MB -4.9%) vs baseline: +5.3%


span - 26/26

✅ add-event

Time: ✅ 24.021ms (SLO: <26.200ms -8.3%) vs baseline: -0.4%

Memory: ✅ 51.161MB (SLO: <53.000MB -3.5%) vs baseline: +5.3%


✅ add-metrics

Time: ✅ 91.845ms (SLO: <98.350ms -6.6%) vs baseline: -0.5%

Memory: ✅ 606.778MB (SLO: <961.000MB 📉 -36.9%) vs baseline: +4.7%


✅ add-tags

Time: ✅ 149.819ms (SLO: <168.550ms 📉 -11.1%) vs baseline: -0.1%

Memory: ✅ 607.581MB (SLO: <962.500MB 📉 -36.9%) vs baseline: +4.8%


✅ get-context

Time: ✅ 22.269ms (SLO: <23.700ms -6.0%) vs baseline: -0.2%

Memory: ✅ 49.994MB (SLO: <53.000MB -5.7%) vs baseline: +5.4%


✅ is-recording

Time: ✅ 22.496ms (SLO: <23.900ms -5.9%) vs baseline: -0.7%

Memory: ✅ 49.998MB (SLO: <53.000MB -5.7%) vs baseline: +5.3%


✅ record-exception

Time: ✅ 42.748ms (SLO: <44.500ms -3.9%) vs baseline: +0.3%

Memory: ✅ 42.823MB (SLO: <53.000MB 📉 -19.2%) vs baseline: +5.1%


✅ set-status

Time: ✅ 24.427ms (SLO: <26.000ms -6.0%) vs baseline: +0.4%

Memory: ✅ 49.959MB (SLO: <53.000MB -5.7%) vs baseline: +5.2%


✅ start

Time: ✅ 22.239ms (SLO: <23.500ms -5.4%) vs baseline: -0.3%

Memory: ✅ 49.969MB (SLO: <53.000MB -5.7%) vs baseline: +5.3%


✅ start-finish

Time: ✅ 52.216ms (SLO: <55.500ms -5.9%) vs baseline: ~same

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.2%


✅ start-finish-telemetry

Time: ✅ 53.249ms (SLO: <58.300ms -8.7%) vs baseline: -0.6%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.5%


✅ start-finish-traceid128

Time: ✅ 55.310ms (SLO: <60.050ms -7.9%) vs baseline: -0.6%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.3%


✅ start-traceid128

Time: ✅ 22.767ms (SLO: <24.600ms -7.5%) vs baseline: ~same

Memory: ✅ 50.016MB (SLO: <53.000MB -5.6%) vs baseline: +5.2%


✅ update-name

Time: ✅ 23.200ms (SLO: <24.100ms -3.7%) vs baseline: +0.5%

Memory: ✅ 50.579MB (SLO: <53.000MB -4.6%) vs baseline: +5.0%


telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.245µs (SLO: <20.000µs 📉 -83.8%) vs baseline: +0.6%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +5.2%


✅ 1-count-metrics-100-times

Time: ✅ 216.922µs (SLO: <250.000µs 📉 -13.2%) vs baseline: -0.6%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +5.5%


✅ 1-distribution-metric-1-times

Time: ✅ 3.316µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +9.0%

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%


✅ 1-distribution-metrics-100-times

Time: ✅ 196.522µs (SLO: <220.000µs 📉 -10.7%) vs baseline: -1.0%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.6%


✅ 1-gauge-metric-1-times

Time: ✅ 2.110µs (SLO: <20.000µs 📉 -89.4%) vs baseline: -1.9%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.2%


✅ 1-gauge-metrics-100-times

Time: ✅ 125.707µs (SLO: <150.000µs 📉 -16.2%) vs baseline: +0.3%

Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.3%


✅ 1-rate-metric-1-times

Time: ✅ 3.222µs (SLO: <20.000µs 📉 -83.9%) vs baseline: -0.4%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.4%


✅ 1-rate-metrics-100-times

Time: ✅ 219.565µs (SLO: <250.000µs 📉 -12.2%) vs baseline: ~same

Memory: ✅ 31.438MB (SLO: <34.000MB -7.5%) vs baseline: +5.2%


✅ 100-count-metrics-100-times

Time: ✅ 21.563ms (SLO: <23.500ms -8.2%) vs baseline: -0.2%

Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +5.5%


✅ 100-distribution-metrics-100-times

Time: ✅ 2.081ms (SLO: <2.250ms -7.5%) vs baseline: +1.7%

Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +6.8%


✅ 100-gauge-metrics-100-times

Time: ✅ 1.279ms (SLO: <1.550ms 📉 -17.5%) vs baseline: -0.8%

Memory: ✅ 31.556MB (SLO: <34.000MB -7.2%) vs baseline: +6.0%


✅ 100-rate-metrics-100-times

Time: ✅ 2.225ms (SLO: <2.550ms 📉 -12.7%) vs baseline: -0.6%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.1%


✅ flush-1-metric

Time: ✅ 4.538µs (SLO: <20.000µs 📉 -77.3%) vs baseline: +6.0%

Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +5.2%


✅ flush-100-metrics

Time: ✅ 182.573µs (SLO: <250.000µs 📉 -27.0%) vs baseline: -1.5%

Memory: ✅ 31.831MB (SLO: <34.000MB -6.4%) vs baseline: +5.6%


✅ flush-1000-metrics

Time: ✅ 2.206ms (SLO: <2.500ms 📉 -11.8%) vs baseline: -1.7%

Memory: ✅ 32.657MB (SLO: <34.500MB -5.3%) vs baseline: +5.6%


tracer - 6/6

✅ large

Time: ✅ 30.720ms (SLO: <32.950ms -6.8%) vs baseline: +0.1%

Memory: ✅ 33.030MB (SLO: <34.500MB -4.3%) vs baseline: +5.1%


✅ medium

Time: ✅ 3.006ms (SLO: <3.200ms -6.1%) vs baseline: +0.4%

Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +5.2%


✅ small

Time: ✅ 339.596µs (SLO: <370.000µs -8.2%) vs baseline: +0.5%

Memory: ✅ 31.418MB (SLO: <34.000MB -7.6%) vs baseline: +4.9%

ℹ️ Scenarios Missing SLO Configuration (14 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-context_with_data_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_only_all_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • coreapiscenario-core_dispatch_with_results_only_all_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline

@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch from cdfa633 to 0870b87 Compare September 16, 2025 07:56
@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch 8 times, most recently from 0817401 to 6067107 Compare September 18, 2025 12:18
@florentinl florentinl marked this pull request as ready for review September 18, 2025 13:10
@florentinl florentinl requested review from a team as code owners September 18, 2025 13:10
---
features:
- |
tracing: Added support for resource renaming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a better description here? what is this? why/when should someone enable? are there any public docs on this feature we can link to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a description of the feature. Trying to answer both questions.
There are no public docs for now on this feature, this is experimental.

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a scenario to flask_simple and django_simple benchmarks for this feature? would be good to know the performance trade off of enabling it.

class ResourceRenamingProcessor(SpanProcessor):
def __init__(self):
self._URL_PATH_EXTRACTION_RE = re.compile(
r"^(?P<protocol>[a-z]+://(?P<host>[^?/]+))?(?P<path>/[^?]*)(?P<query>(\?).*)?$"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to use urllib.parse.urlparse to separate out the path from query/fragment/etc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I started to work on that feature, I discovered that, in the general case, urllib.parse and any regular parsing method could be really strict, while we could have, on some orgs, weird urls for many different reasons.
Instead of failing completely in those cases, using a regex is more robust and in many occasion, can successfully extract the path of the url, even if it's polluted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of those examples are covered in the tests? (some of those are parsed weird with urlparse, but fine with the regex?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed it with @christophe-papazian and we can use urllib here.

@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch 2 times, most recently from 629f064 to 39939c9 Compare September 19, 2025 14:44
@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch from 5d6de1a to 01d4016 Compare September 19, 2025 14:53
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2025

Benchmarks

Benchmark execution time: 2025-09-19 14:58:11

Comparing candidate commit 629f064 in PR branch florentin.labelle/APPSEC-58892/resource-renaming with baseline commit 19ca460 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 553 metrics, 9 unstable metrics.

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+358.567ns; +637.755ns] or [+7.442%; +13.236%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+397.585ns; +448.035ns] or [+13.327%; +15.018%]

@florentinl florentinl force-pushed the florentin.labelle/APPSEC-58892/resource-renaming branch from 01d4016 to e61c3ad Compare September 19, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants