Skip to content

Conversation

@wconti27
Copy link
Contributor

@wconti27 wconti27 commented Nov 20, 2025

What does this PR do?

ONCE ROCHS ORCHESTRION IMPROVEMENTS LAND, WRAPPERS.JS WILL BE REMOVED. TEMP WORKAROUND

Summary of Changes:

  • added wrappers helpers for instrumentation (I expect to not need this once Orchestrion-JS works and is usable)
  • added assertion helper that allows for asserting type matching for assertObjectContains (useful for asserting error tags since stacktrace / error message is difficult to get exact values)
  • added subscription helpers for TracingChannel subscriptions for plugins to use. Helps plugins subscribe to the correct channels given sometimes we need to use addBind, other times we need to use addSub
  • added abstraction layer for plugin tests. The abstraction handles withVersions setup, mock agent setup, tracer initialization, and mock agent closing. Allows plugin test files to be simpler, less to generate for an AI Agent.

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Overall package size

Self size: 13.42 MB
Deduped: 113.61 MB
No deduping: 128.63 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.2 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.76%. Comparing base (f04d912) to head (983d047).
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/plugins/cache.js 0.00% 5 Missing ⚠️
packages/dd-trace/src/plugins/consumer.js 0.00% 5 Missing ⚠️
packages/dd-trace/src/plugins/producer.js 0.00% 5 Missing ⚠️
packages/dd-trace/src/plugins/tracing.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6955      +/-   ##
==========================================
+ Coverage   84.61%   84.76%   +0.15%     
==========================================
  Files         505      513       +8     
  Lines       21166    21534     +368     
==========================================
+ Hits        17909    18253     +344     
- Misses       3257     3281      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2025

Benchmarks

Benchmark execution time: 2025-11-26 15:17:04

Comparing candidate commit 983d047 in PR branch conti/pre-tooling-changes with baseline commit f04d912 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 286 metrics, 34 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants