Skip to content

Conversation

@faydef
Copy link
Contributor

@faydef faydef commented Nov 20, 2025

What does this PR do?

This PR excludes creating pipelines based on graphite branches. This comes as it duplicates benchmark runs and induces errors in branch referencing.
image
Example of pipeline:
Graphite based pipeline
Commit reference
Actual reference pipeline with correct commit

Motivation

We have had a shortage of metal instances to run benchmarks on and are culling out these duplicate pipelines.

Tests

Branch with graphite like name created based on current Gitlab config on main: pipeline exists
Branch with graphite like name created based on current Gitlab config on this branch : pipeline does not exist.

For the commit sha shared yesterday, there were 2 pipelines
graphite one: 10:58 am - failed
expected branch: 1:40 pm - successful
(both triggered from codesync) meaning the benchmarks will be triggered normally on push to the right branch.
The PR checks being based on the latest pipeline referring to the head, no pipepline from graphite and the right pipeline from the right branch should fix it!

Additional Notes

@faydef faydef requested a review from a team as a code owner November 20, 2025 15:12
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 20, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fa36853 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Overall package size

Self size: 13.38 MB
Deduped: 113.58 MB
No deduping: 128.59 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.2 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.33%. Comparing base (7f5305e) to head (fa36853).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6953      +/-   ##
==========================================
- Coverage   84.81%   83.33%   -1.49%     
==========================================
  Files         513      513              
  Lines       21521    21521              
==========================================
- Hits        18253    17934     -319     
- Misses       3268     3587     +319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BridgeAR
BridgeAR previously approved these changes Nov 21, 2025
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable for me

@pr-commenter
Copy link

pr-commenter bot commented Nov 24, 2025

Benchmarks

Benchmark execution time: 2025-11-24 10:40:19

Comparing candidate commit fa36853 in PR branch fayssal/exclude-grahite with baseline commit 7f5305e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics.

@faydef
Copy link
Contributor Author

faydef commented Nov 24, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 24, 2025

View all feedbacks in Devflow UI.

2025-11-24 13:51:34 UTC ℹ️ Start processing command /merge


2025-11-24 13:51:37 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.


2025-11-24 14:02:45 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@faydef faydef merged commit 693f054 into master Nov 24, 2025
788 checks passed
@faydef faydef deleted the fayssal/exclude-grahite branch November 24, 2025 14:02
@dd-octo-sts dd-octo-sts bot mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants