Skip to content

Conversation

@sabrenner
Copy link
Collaborator

What does this PR do?

Ensures recently added methods (annotationContext, registerProcessor, and deregisterProcessor) are on the no-op sdk, and are properly tested.

Motivation

The LLM Observability SDK should not crash with these functions when it is disabled.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Overall package size

Self size: 13.25 MB
Deduped: 116.15 MB
No deduping: 131.17 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.60%. Comparing base (f04d912) to head (427fa8e).

Files with missing lines Patch % Lines
packages/dd-trace/src/llmobs/noop.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6949      +/-   ##
==========================================
- Coverage   84.61%   84.60%   -0.01%     
==========================================
  Files         505      505              
  Lines       21166    21167       +1     
==========================================
  Hits        17909    17909              
- Misses       3257     3258       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2025

Benchmarks

Benchmark execution time: 2025-11-20 20:36:08

Comparing candidate commit 427fa8e in PR branch sabrenner/llmobs-annotation-context-noop with baseline commit f04d912 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 287 metrics, 33 unstable metrics.

Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: we can verify these are aligned by verifying the keys are identical.

@sabrenner
Copy link
Collaborator Author

@BridgeAR yeah i actually had that locally but thought that it felt too gimmicky somehow 😅 but i can add that back in as well!

@sabrenner sabrenner marked this pull request as ready for review November 20, 2025 14:46
@sabrenner sabrenner requested a review from a team as a code owner November 20, 2025 14:46
@datadog-official
Copy link

datadog-official bot commented Nov 20, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

mocha@latest dynamic instrumentation runs retries with dynamic instrumentation from integration-tests/mocha/mocha.spec.js (Datadog)
Cannot read properties of undefined (reading 'logMessage')

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 427fa8e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@sabrenner sabrenner merged commit 2fd9b1d into master Nov 20, 2025
833 of 836 checks passed
@sabrenner sabrenner deleted the sabrenner/llmobs-annotation-context-noop branch November 20, 2025 21:38
dd-octo-sts bot pushed a commit that referenced this pull request Nov 20, 2025
…6949)

* add in forgotten no-op functions

* update & make no-op tests more explicit

* add test to verify method consistency
@dd-octo-sts dd-octo-sts bot mentioned this pull request Nov 20, 2025
juan-fernandez pushed a commit that referenced this pull request Nov 21, 2025
…6949)

* add in forgotten no-op functions

* update & make no-op tests more explicit

* add test to verify method consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants