Skip to content

Conversation

@patrick-vandusen-creditgenie

What does this PR do?

Accepts arrays of tag values in dogstatsd.

Motivation

We need it, Datadog supports it, datadog-lambda-js can already do it, there's no reason dogstatsd shouldn't be able to do it too.

@patrick-vandusen-creditgenie patrick-vandusen-creditgenie requested a review from a team as a code owner April 17, 2025 18:15
@BridgeAR
Copy link
Collaborator

BridgeAR commented Apr 23, 2025

@patrick-vandusen-creditgenie adding this is going to cause quite some overhead for everyone. Would it not be fine to just use a small helper method that calls the API after transforming it to the regular format?

@patrick-vandusen-creditgenie
Copy link
Author

@BridgeAR

@patrick-vandusen-creditgenie adding this is going to cause quite some overhead for everyone.

I haven't noted significant overhead from the use of Array.isArray, can you elaborate on why you believe that will be the case?

Would it not be fine to just use a small helper method that calls the API after transforming it to the regular format?

I tried to find a way to do this within the existing interface of dd-trace but wasn't able to, could you explain how you would approach this?

@rochdev
Copy link
Member

rochdev commented May 19, 2025

@tlhunter What was the reason the original API didn't accept ['foo:bar', 'foo:baz'] since that's the format of the underlying implementation?

@rochdev
Copy link
Member

rochdev commented May 19, 2025

I opened #5748 to support this in the same way as the underlying protocol/implementation instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants