Skip to content

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Feb 2, 2023

What does this PR do?

Due to a bad string concatenation, we were sometimes showing // instead of / in the boundary between a url's hostname and its path. This PR fixes it by using new URL

Motivation

Fix log error message when a request to a given intake fails.

@juan-fernandez juan-fernandez marked this pull request as ready for review February 2, 2023 11:38
@juan-fernandez juan-fernandez requested a review from a team as a code owner February 2, 2023 11:38
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Overall package size

Self size: 3.73 MB
Deduped: 57.23 MB
No deduping: 63.83 MB

Dependency sizes

name version self size total size
@datadog/pprof 1.1.1 10.9 MB 17.75 MB
@datadog/native-iast-taint-tracking 1.1.0 13.38 MB 13.39 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 1.1.2 2.06 MB 2.08 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #2757 (133bf54) into master (5413b06) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2757      +/-   ##
==========================================
- Coverage   89.24%   89.13%   -0.12%     
==========================================
  Files         314      305       -9     
  Lines       10863    10623     -240     
  Branches       33       33              
==========================================
- Hits         9695     9469     -226     
+ Misses       1168     1154      -14     
Impacted Files Coverage Δ
packages/dd-trace/src/exporters/common/request.js 88.88% <100.00%> (+0.28%) ⬆️
packages/datadog-instrumentations/src/rhea.js
packages/datadog-plugin-rhea/src/producer.js
packages/datadog-plugin-amqp10/src/consumer.js
packages/datadog-plugin-rhea/src/consumer.js
packages/datadog-plugin-amqp10/src/util.js
packages/datadog-plugin-rhea/src/index.js
packages/datadog-plugin-amqp10/src/producer.js
packages/datadog-plugin-amqp10/src/index.js
packages/datadog-instrumentations/src/amqp10.js

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Feb 2, 2023

Benchmarks

Comparing candidate commit 133bf54 in PR branch juan-fernandez/fix-log-error-message with baseline commit 5413b06 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 1198 cases.

scenario:appsec-appsec-enabled-with-attacks-16

  • 🟥 cpu_system_time [+1.644ms; +7.650ms] or [+3.968%; +18.463%]

scenario:encoders-0.4-18

  • 🟥 max_rss_usage [+6.011KB; +6.207KB] or [+2.978%; +3.075%]

@juan-fernandez juan-fernandez merged commit aa9c8f4 into master Feb 2, 2023
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-log-error-message branch February 2, 2023 18:43
This was referenced Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants