remove fs plugin #2137
Merged
remove fs plugin #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove
fsplugin.Motivation
This plugin was added a while ago with no clear use case. At best, it's unnecessary noise for most applications, and at worst, it causes issues like exposing errors that are later handled, general performance problems, etc. Removing this integration is the best course of action for now, and if there are clear use cases for it that users request afterwards, we can always bring it back but the result will likely be vastly different than the current approach since it should focus on the use case and not attempt to instrument every single function call including long-lived streams.