Skip to content

Return noop continuation when not async propagating #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

Return noop continuation when not async propagating #8365

merged 1 commit into from
Feb 11, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Feb 11, 2025

Motivation

Improves API robustness

Contributor Checklist

Jira ticket: [/APMAPI-955]

@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Feb 11, 2025
@mcculls mcculls requested a review from a team as a code owner February 11, 2025 11:26
@mcculls mcculls force-pushed the mcculls/noop-continuation branch from 79ed9a2 to 145b63f Compare February 11, 2025 11:40
@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/noop-continuation
git_commit_date 1739276388 1739275942
git_commit_sha 652b465 2c02593
release_version 1.47.0-SNAPSHOT~652b46574b 1.47.0-SNAPSHOT~2c02593c3d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739278711 1739278711
ci_job_id 802704613 802704613
ci_pipeline_id 55517607 55517607
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tp66uhdj-project-304-concurrent-0-yjmlnzf4 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tp66uhdj-project-304-concurrent-0-yjmlnzf4 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055052
Total [baseline] (8.681 s) : 0, 8680808
Agent [candidate] (1.047 s) : 0, 1047142
Total [candidate] (8.681 s) : 0, 8681089
section iast
Agent [baseline] (1.172 s) : 0, 1172298
Total [baseline] (9.206 s) : 0, 9206086
Agent [candidate] (1.18 s) : 0, 1179550
Total [candidate] (9.193 s) : 0, 9192856
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1189185
Total [baseline] (9.223 s) : 0, 9223336
Agent [candidate] (1.173 s) : 0, 1172535
Total [candidate] (9.185 s) : 0, 9185113
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176094
Total [baseline] (9.233 s) : 0, 9232549
Agent [candidate] (1.169 s) : 0, 1168518
Total [candidate] (9.191 s) : 0, 9191098
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.172 s 117.246 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.189 s 134.132 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.176 s 121.042 ms (11.5%)
Total tracing 8.681 s -
Total iast 9.206 s 525.278 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.223 s 542.528 ms (6.2%)
Total iast_TELEMETRY_OFF 9.233 s 551.741 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.18 s 132.408 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 125.393 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.169 s 121.376 ms (11.6%)
Total tracing 8.681 s -
Total iast 9.193 s 511.767 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.185 s 504.024 ms (5.8%)
Total iast_TELEMETRY_OFF 9.191 s 510.009 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.967 ms) : 0, 724967
BytebuddyAgent [candidate] (720.467 ms) : 0, 720467
GlobalTracer [baseline] (246.254 ms) : 0, 246254
GlobalTracer [candidate] (244.553 ms) : 0, 244553
AppSec [baseline] (55.396 ms) : 0, 55396
AppSec [candidate] (55.302 ms) : 0, 55302
Remote Config [baseline] (720.664 µs) : 0, 721
Remote Config [candidate] (719.287 µs) : 0, 719
Telemetry [baseline] (12.37 ms) : 0, 12370
Telemetry [candidate] (10.869 ms) : 0, 10869
section iast
BytebuddyAgent [baseline] (834.874 ms) : 0, 834874
BytebuddyAgent [candidate] (839.305 ms) : 0, 839305
GlobalTracer [baseline] (233.141 ms) : 0, 233141
GlobalTracer [candidate] (234.68 ms) : 0, 234680
IAST [baseline] (22.833 ms) : 0, 22833
IAST [candidate] (23.958 ms) : 0, 23958
AppSec [baseline] (56.876 ms) : 0, 56876
AppSec [candidate] (56.911 ms) : 0, 56911
Remote Config [baseline] (612.478 µs) : 0, 612
Remote Config [candidate] (625.246 µs) : 0, 625
Telemetry [baseline] (8.754 ms) : 0, 8754
Telemetry [candidate] (8.793 ms) : 0, 8793
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (846.964 ms) : 0, 846964
BytebuddyAgent [candidate] (833.953 ms) : 0, 833953
GlobalTracer [baseline] (236.531 ms) : 0, 236531
GlobalTracer [candidate] (233.975 ms) : 0, 233975
IAST [baseline] (23.367 ms) : 0, 23367
IAST [candidate] (22.985 ms) : 0, 22985
AppSec [baseline] (57.492 ms) : 0, 57492
AppSec [candidate] (57.116 ms) : 0, 57116
Remote Config [baseline] (626.899 µs) : 0, 627
Remote Config [candidate] (612.859 µs) : 0, 613
Telemetry [baseline] (8.811 ms) : 0, 8811
Telemetry [candidate] (8.645 ms) : 0, 8645
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.764 ms) : 0, 836764
BytebuddyAgent [candidate] (831.712 ms) : 0, 831712
GlobalTracer [baseline] (234.723 ms) : 0, 234723
GlobalTracer [candidate] (233.481 ms) : 0, 233481
IAST [baseline] (24.97 ms) : 0, 24970
IAST [candidate] (26.226 ms) : 0, 26226
AppSec [baseline] (54.971 ms) : 0, 54971
AppSec [candidate] (52.731 ms) : 0, 52731
Remote Config [baseline] (617.46 µs) : 0, 617
Remote Config [candidate] (604.639 µs) : 0, 605
Telemetry [baseline] (8.72 ms) : 0, 8720
Telemetry [candidate] (8.561 ms) : 0, 8561
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041510
Total [baseline] (10.393 s) : 0, 10393460
Agent [candidate] (1.041 s) : 0, 1041359
Total [candidate] (10.498 s) : 0, 10497631
section appsec
Agent [baseline] (1.186 s) : 0, 1185940
Total [baseline] (10.768 s) : 0, 10768058
Agent [candidate] (1.194 s) : 0, 1194138
Total [candidate] (10.759 s) : 0, 10758941
section iast
Agent [baseline] (1.173 s) : 0, 1173430
Total [baseline] (10.951 s) : 0, 10951113
Agent [candidate] (1.181 s) : 0, 1181259
Total [candidate] (10.948 s) : 0, 10947527
section profiling
Agent [baseline] (1.261 s) : 0, 1260649
Total [baseline] (10.813 s) : 0, 10813443
Agent [candidate] (1.265 s) : 0, 1265414
Total [candidate] (10.929 s) : 0, 10929058
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.186 s 144.43 ms (13.9%)
Agent iast 1.173 s 131.921 ms (12.7%)
Agent profiling 1.261 s 219.14 ms (21.0%)
Total tracing 10.393 s -
Total appsec 10.768 s 374.599 ms (3.6%)
Total iast 10.951 s 557.653 ms (5.4%)
Total profiling 10.813 s 419.983 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.194 s 152.779 ms (14.7%)
Agent iast 1.181 s 139.9 ms (13.4%)
Agent profiling 1.265 s 224.055 ms (21.5%)
Total tracing 10.498 s -
Total appsec 10.759 s 261.31 ms (2.5%)
Total iast 10.948 s 449.896 ms (4.3%)
Total profiling 10.929 s 431.427 ms (4.1%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.317 ms) : 0, 716317
BytebuddyAgent [candidate] (715.629 ms) : 0, 715629
GlobalTracer [baseline] (242.964 ms) : 0, 242964
GlobalTracer [candidate] (243.075 ms) : 0, 243075
AppSec [baseline] (55.051 ms) : 0, 55051
AppSec [candidate] (55.164 ms) : 0, 55164
Remote Config [baseline] (702.861 µs) : 0, 703
Remote Config [candidate] (709.79 µs) : 0, 710
Telemetry [baseline] (11.385 ms) : 0, 11385
Telemetry [candidate] (11.55 ms) : 0, 11550
section appsec
BytebuddyAgent [baseline] (733.473 ms) : 0, 733473
BytebuddyAgent [candidate] (739.037 ms) : 0, 739037
GlobalTracer [baseline] (240.85 ms) : 0, 240850
GlobalTracer [candidate] (242.581 ms) : 0, 242581
IAST [baseline] (21.594 ms) : 0, 21594
IAST [candidate] (21.998 ms) : 0, 21998
AppSec [baseline] (176.77 ms) : 0, 176770
AppSec [candidate] (177.259 ms) : 0, 177259
Remote Config [baseline] (664.49 µs) : 0, 664
Remote Config [candidate] (660.508 µs) : 0, 661
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.306 ms) : 0, 8306
section iast
BytebuddyAgent [baseline] (834.542 ms) : 0, 834542
BytebuddyAgent [candidate] (841.345 ms) : 0, 841345
GlobalTracer [baseline] (233.867 ms) : 0, 233867
GlobalTracer [candidate] (235.18 ms) : 0, 235180
IAST [baseline] (22.944 ms) : 0, 22944
IAST [candidate] (23.209 ms) : 0, 23209
AppSec [baseline] (57.546 ms) : 0, 57546
AppSec [candidate] (56.689 ms) : 0, 56689
Remote Config [baseline] (622.717 µs) : 0, 623
Remote Config [candidate] (615.22 µs) : 0, 615
Telemetry [baseline] (8.665 ms) : 0, 8665
Telemetry [candidate] (8.727 ms) : 0, 8727
section profiling
BytebuddyAgent [baseline] (705.935 ms) : 0, 705935
BytebuddyAgent [candidate] (706.806 ms) : 0, 706806
GlobalTracer [baseline] (352.834 ms) : 0, 352834
GlobalTracer [candidate] (355.927 ms) : 0, 355927
AppSec [baseline] (55.101 ms) : 0, 55101
AppSec [candidate] (54.776 ms) : 0, 54776
Remote Config [baseline] (691.399 µs) : 0, 691
Remote Config [candidate] (716.225 µs) : 0, 716
Telemetry [baseline] (8.86 ms) : 0, 8860
Telemetry [candidate] (8.98 ms) : 0, 8980
ProfilingAgent [baseline] (95.007 ms) : 0, 95007
ProfilingAgent [candidate] (95.868 ms) : 0, 95868
Profiling [baseline] (95.031 ms) : 0, 95031
Profiling [candidate] (95.893 ms) : 0, 95893
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-11T12:32:41 2025-02-11T12:39:48
git_branch master mcculls/noop-continuation
git_commit_date 1739276388 1739275942
git_commit_sha 652b465 2c02593
release_version 1.47.0-SNAPSHOT~652b46574b 1.47.0-SNAPSHOT~2c02593c3d
start_time 2025-02-11T12:32:27 2025-02-11T12:39:34
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739277948 1739277948
ci_job_id 802704614 802704614
ci_pipeline_id 55517607 55517607
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-b9vwe93j-project-304-concurrent-0-znkmrzwp 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-b9vwe93j-project-304-concurrent-0-znkmrzwp 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b
    dateFormat X
    axisFormat %s
section baseline
no_agent (390.092 µs) : 370, 410
.   : milestone, 390,
iast (516.291 µs) : 495, 538
.   : milestone, 516,
iast_FULL (748.657 µs) : 727, 771
.   : milestone, 749,
iast_GLOBAL (563.68 µs) : 542, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (515.008 µs) : 493, 537
.   : milestone, 515,
iast_INACTIVE (467.0 µs) : 445, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (502.339 µs) : 481, 524
.   : milestone, 502,
tracing (456.698 µs) : 434, 479
.   : milestone, 457,
section candidate
no_agent (381.258 µs) : 361, 401
.   : milestone, 381,
iast (520.573 µs) : 499, 542
.   : milestone, 521,
iast_FULL (753.097 µs) : 731, 775
.   : milestone, 753,
iast_GLOBAL (561.219 µs) : 540, 583
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (517.195 µs) : 495, 539
.   : milestone, 517,
iast_INACTIVE (467.189 µs) : 446, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (505.398 µs) : 482, 529
.   : milestone, 505,
tracing (458.495 µs) : 437, 480
.   : milestone, 458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 390.092 µs [370.384 µs, 409.8 µs] -
iast 516.291 µs [494.64 µs, 537.941 µs] 126.199 µs (32.4%)
iast_FULL 748.657 µs [726.589 µs, 770.725 µs] 358.565 µs (91.9%)
iast_GLOBAL 563.68 µs [541.581 µs, 585.78 µs] 173.588 µs (44.5%)
iast_HARDCODED_SECRET_DISABLED 515.008 µs [492.781 µs, 537.236 µs] 124.916 µs (32.0%)
iast_INACTIVE 467.0 µs [445.477 µs, 488.524 µs] 76.908 µs (19.7%)
iast_TELEMETRY_OFF 502.339 µs [480.689 µs, 523.989 µs] 112.247 µs (28.8%)
tracing 456.698 µs [434.257 µs, 479.139 µs] 66.605 µs (17.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.258 µs [361.357 µs, 401.159 µs] -
iast 520.573 µs [498.75 µs, 542.396 µs] 139.315 µs (36.5%)
iast_FULL 753.097 µs [731.139 µs, 775.055 µs] 371.839 µs (97.5%)
iast_GLOBAL 561.219 µs [539.629 µs, 582.809 µs] 179.961 µs (47.2%)
iast_HARDCODED_SECRET_DISABLED 517.195 µs [495.273 µs, 539.118 µs] 135.937 µs (35.7%)
iast_INACTIVE 467.189 µs [445.779 µs, 488.598 µs] 85.93 µs (22.5%)
iast_TELEMETRY_OFF 505.398 µs [482.121 µs, 528.674 µs] 124.139 µs (32.6%)
tracing 458.495 µs [437.484 µs, 479.507 µs] 77.237 µs (20.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.385 ms) : 1366, 1405
.   : milestone, 1385,
appsec (1.754 ms) : 1730, 1777
.   : milestone, 1754,
appsec_no_iast (1.759 ms) : 1734, 1784
.   : milestone, 1759,
iast (1.53 ms) : 1506, 1555
.   : milestone, 1530,
profiling (1.493 ms) : 1469, 1516
.   : milestone, 1493,
tracing (1.468 ms) : 1442, 1493
.   : milestone, 1468,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.75 ms) : 1727, 1774
.   : milestone, 1750,
appsec_no_iast (1.771 ms) : 1747, 1795
.   : milestone, 1771,
iast (1.503 ms) : 1478, 1528
.   : milestone, 1503,
profiling (1.517 ms) : 1493, 1540
.   : milestone, 1517,
tracing (1.51 ms) : 1485, 1534
.   : milestone, 1510,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.385 ms [1.366 ms, 1.405 ms] -
appsec 1.754 ms [1.73 ms, 1.777 ms] 368.421 µs (26.6%)
appsec_no_iast 1.759 ms [1.734 ms, 1.784 ms] 373.53 µs (27.0%)
iast 1.53 ms [1.506 ms, 1.555 ms] 144.82 µs (10.5%)
profiling 1.493 ms [1.469 ms, 1.516 ms] 107.234 µs (7.7%)
tracing 1.468 ms [1.442 ms, 1.493 ms] 82.413 µs (5.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.75 ms [1.727 ms, 1.774 ms] 390.357 µs (28.7%)
appsec_no_iast 1.771 ms [1.747 ms, 1.795 ms] 410.992 µs (30.2%)
iast 1.503 ms [1.478 ms, 1.528 ms] 143.036 µs (10.5%)
profiling 1.517 ms [1.493 ms, 1.54 ms] 156.602 µs (11.5%)
tracing 1.51 ms [1.485 ms, 1.534 ms] 149.62 µs (11.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/noop-continuation
git_commit_date 1739276388 1739275942
git_commit_sha 652b465 2c02593
release_version 1.47.0-SNAPSHOT~652b46574b 1.47.0-SNAPSHOT~2c02593c3d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1739278235 1739278235
ci_job_id 802704615 802704615
ci_pipeline_id 55517607 55517607
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tp66uhdj-project-304-concurrent-1-6hb6zyf3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tp66uhdj-project-304-concurrent-1-6hb6zyf3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
appsec (15.263 s) : 15263000, 15263000
.   : milestone, 15263000,
iast (18.79 s) : 18790000, 18790000
.   : milestone, 18790000,
iast_GLOBAL (17.823 s) : 17823000, 17823000
.   : milestone, 17823000,
profiling (15.165 s) : 15165000, 15165000
.   : milestone, 15165000,
tracing (14.82 s) : 14820000, 14820000
.   : milestone, 14820000,
section candidate
no_agent (15.418 s) : 15418000, 15418000
.   : milestone, 15418000,
appsec (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
iast (18.724 s) : 18724000, 18724000
.   : milestone, 18724000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
.   : milestone, 17995000,
profiling (14.978 s) : 14978000, 14978000
.   : milestone, 14978000,
tracing (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.031 s [15.031 s, 15.031 s] -
appsec 15.263 s [15.263 s, 15.263 s] 232.0 ms (1.5%)
iast 18.79 s [18.79 s, 18.79 s] 3.759 s (25.0%)
iast_GLOBAL 17.823 s [17.823 s, 17.823 s] 2.792 s (18.6%)
profiling 15.165 s [15.165 s, 15.165 s] 134.0 ms (0.9%)
tracing 14.82 s [14.82 s, 14.82 s] -211.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.418 s [15.418 s, 15.418 s] -
appsec 15.093 s [15.093 s, 15.093 s] -325.0 ms (-2.1%)
iast 18.724 s [18.724 s, 18.724 s] 3.306 s (21.4%)
iast_GLOBAL 17.995 s [17.995 s, 17.995 s] 2.577 s (16.7%)
profiling 14.978 s [14.978 s, 14.978 s] -440.0 ms (-2.9%)
tracing 15.152 s [15.152 s, 15.152 s] -266.0 ms (-1.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~2c02593c3d, baseline=1.47.0-SNAPSHOT~652b46574b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.376 ms) : 2332, 2419
.   : milestone, 2376,
iast (2.118 ms) : 2063, 2174
.   : milestone, 2118,
iast_GLOBAL (2.162 ms) : 2106, 2217
.   : milestone, 2162,
profiling (1.992 ms) : 1948, 2037
.   : milestone, 1992,
tracing (1.949 ms) : 1906, 1991
.   : milestone, 1949,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.364 ms) : 2321, 2407
.   : milestone, 2364,
iast (2.118 ms) : 2062, 2173
.   : milestone, 2118,
iast_GLOBAL (2.159 ms) : 2103, 2214
.   : milestone, 2159,
profiling (1.973 ms) : 1929, 2016
.   : milestone, 1973,
tracing (1.94 ms) : 1898, 1983
.   : milestone, 1940,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.376 ms [2.332 ms, 2.419 ms] 902.234 µs (61.2%)
iast 2.118 ms [2.063 ms, 2.174 ms] 644.535 µs (43.7%)
iast_GLOBAL 2.162 ms [2.106 ms, 2.217 ms] 688.131 µs (46.7%)
profiling 1.992 ms [1.948 ms, 2.037 ms] 518.717 µs (35.2%)
tracing 1.949 ms [1.906 ms, 1.991 ms] 475.011 µs (32.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.364 ms [2.321 ms, 2.407 ms] 892.527 µs (60.7%)
iast 2.118 ms [2.062 ms, 2.173 ms] 646.123 µs (43.9%)
iast_GLOBAL 2.159 ms [2.103 ms, 2.214 ms] 687.306 µs (46.7%)
profiling 1.973 ms [1.929 ms, 2.016 ms] 501.328 µs (34.1%)
tracing 1.94 ms [1.898 ms, 1.983 ms] 469.004 µs (31.9%)

@mcculls mcculls force-pushed the mcculls/noop-continuation branch 2 times, most recently from 2c02593 to c7a7002 Compare February 11, 2025 12:16
@mcculls mcculls requested a review from a team as a code owner February 11, 2025 12:16
@mcculls mcculls force-pushed the mcculls/noop-continuation branch from c7a7002 to 2fa7d15 Compare February 11, 2025 13:31
@mcculls mcculls enabled auto-merge (squash) February 11, 2025 13:50
@mcculls mcculls merged commit cb0dcc4 into master Feb 11, 2025
200 of 201 checks passed
@mcculls mcculls deleted the mcculls/noop-continuation branch February 11, 2025 14:10
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer