Skip to content

Capture Exception when sending metrics #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Capture Exception when sending metrics #7614

wants to merge 2 commits into from

Conversation

NachoEchevarria
Copy link
Contributor

@NachoEchevarria NachoEchevarria commented Oct 3, 2025 •
edited
Loading

Summary of changes

We are getting some test errors because the flaky attributte sends some telemetry reporting the flaky test failures and, when the telemetry call fails, en exception is thrown and the test itself fails as well.

System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
---- System.IO.IOException : Received an unexpected EOF or 0 bytes from the transport stream.

This error can make any test using telemetry fail if the telemetry endpoint does not respond, for instance, so it can potentially affect many tests.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:tests unit tests, integration tests label Oct 3, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 3, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (80ms)  : 77, 83
     .   : milestone, 80,
    master - mean (79ms)  : 75, 82
     .   : milestone, 79,

    section Baseline
    This PR (7614) - mean (76ms)  : 72, 79
     .   : milestone, 76,
    master - mean (75ms)  : 70, 79
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (1,128ms)  : 1040, 1216
     .   : milestone, 1128,
    master - mean (1,109ms)  : 1036, 1182
     .   : milestone, 1109,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (119ms)  : 115, 124
     .   : milestone, 119,
    master - mean (118ms)  : 113, 122
     .   : milestone, 118,

    section Baseline
    This PR (7614) - mean (118ms)  : 112, 124
     .   : milestone, 118,
    master - mean (117ms)  : 111, 122
     .   : milestone, 117,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (792ms)  : 768, 816
     .   : milestone, 792,
    master - mean (789ms)  : 766, 813
     .   : milestone, 789,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (113ms)  : 109, 118
     .   : milestone, 113,
    master - mean (112ms)  : 108, 116
     .   : milestone, 112,

    section Baseline
    This PR (7614) - mean (112ms)  : 106, 118
     .   : milestone, 112,
    master - mean (110ms)  : 104, 115
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (829ms)  : 767, 891
     .   : milestone, 829,
    master - mean (829ms)  : 771, 886
     .   : milestone, 829,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (104ms)  : 99, 108
     .   : milestone, 104,
    master - mean (103ms)  : 99, 107
     .   : milestone, 103,

    section Baseline
    This PR (7614) - mean (103ms)  : 98, 108
     .   : milestone, 103,
    master - mean (102ms)  : 97, 107
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (711ms)  : 691, 732
     .   : milestone, 711,
    master - mean (710ms)  : 686, 734
     .   : milestone, 710,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (200ms)  : 197, 202
     .   : milestone, 200,
    master - mean (203ms)  : 200, 206
     .   : milestone, 203,

    section Baseline
    This PR (7614) - mean (196ms)  : 192, 201
     .   : milestone, 196,
    master - mean (199ms)  : 195, 203
     .   : milestone, 199,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (1,179ms)  : 1110, 1248
     .   : milestone, 1179,
    master - mean (1,191ms)  : 1135, 1248
     .   : milestone, 1191,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (283ms)  : 278, 289
     .   : milestone, 283,
    master - mean (289ms)  : 284, 295
     .   : milestone, 289,

    section Baseline
    This PR (7614) - mean (283ms)  : 279, 288
     .   : milestone, 283,
    master - mean (289ms)  : 280, 297
     .   : milestone, 289,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (945ms)  : 905, 985
     .   : milestone, 945,
    master - mean (953ms)  : 908, 998
     .   : milestone, 953,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (286ms)  : 280, 293
     .   : milestone, 286,
    master - mean (286ms)  : 281, 291
     .   : milestone, 286,

    section Baseline
    This PR (7614) - mean (285ms)  : 279, 291
     .   : milestone, 285,
    master - mean (285ms)  : 280, 289
     .   : milestone, 285,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (998ms)  : 943, 1053
     .   : milestone, 998,
    master - mean (1,033ms)  : 960, 1105
     .   : milestone, 1033,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7614) - mean (276ms)  : 269, 284
     .   : milestone, 276,
    master - mean (285ms)  : 273, 297
     .   : milestone, 285,

    section Baseline
    This PR (7614) - mean (274ms)  : 267, 282
     .   : milestone, 274,
    master - mean (284ms)  : 272, 295
     .   : milestone, 284,

    section CallTarget+Inlining+NGEN
    This PR (7614) - mean (860ms)  : 836, 883
     .   : milestone, 860,
    master - mean (882ms)  : 842, 921
     .   : milestone, 882,
Loading

@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 3, 2025 10:28
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner October 3, 2025 10:28
bouwkast
bouwkast approved these changes Oct 3, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwkast bouwkast bouwkast approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEchevarria @bouwkast