Skip to content

[Profiler/Tracer] Bump to libdatadog v21 #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

[Profiler/Tracer] Bump to libdatadog v21 #7560

wants to merge 18 commits into from
+91 −51

Conversation

gleocadie
Copy link
Collaborator

Summary of changes

Bump to libdatadog v21.

Reason for change

This version provides fixes for crashtracker.

Implementation details

Update vcpkg and cmake files.

Test coverage

Other details

@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Sep 25, 2025
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Sep 25, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (72ms)  : 70, 73
     .   : milestone, 72,
    master - mean (71ms)  : 70, 73
     .   : milestone, 71,

    section Baseline
    This PR (7560) - mean (68ms)  : 67, 69
     .   : milestone, 68,
    master - mean (68ms)  : 66, 69
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (1,051ms)  : 993, 1109
     .   : milestone, 1051,
    master - mean (1,042ms)  : 1004, 1080
     .   : milestone, 1042,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (106ms)  : 105, 107
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7560) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (105ms)  : 103, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (741ms)  : 720, 762
     .   : milestone, 741,
    master - mean (745ms)  : 719, 772
     .   : milestone, 745,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7560) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (94ms)  : 91, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (708ms)  : 668, 748
     .   : milestone, 708,
    master - mean (705ms)  : 678, 732
     .   : milestone, 705,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (93ms)  : 91, 94
     .   : milestone, 93,
    master - mean (92ms)  : 91, 94
     .   : milestone, 92,

    section Baseline
    This PR (7560) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (659ms)  : 649, 669
     .   : milestone, 659,
    master - mean (662ms)  : 647, 677
     .   : milestone, 662,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (194ms)  : 191, 196
     .   : milestone, 194,
    master - mean (195ms)  : 192, 197
     .   : milestone, 195,

    section Baseline
    This PR (7560) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 188, 193
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (1,160ms)  : 1098, 1223
     .   : milestone, 1160,
    master - mean (1,164ms)  : 1101, 1227
     .   : milestone, 1164,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (274ms)  : 269, 279
     .   : milestone, 274,
    master - mean (274ms)  : 270, 279
     .   : milestone, 274,

    section Baseline
    This PR (7560) - mean (274ms)  : 269, 279
     .   : milestone, 274,
    master - mean (273ms)  : 268, 279
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (937ms)  : 886, 989
     .   : milestone, 937,
    master - mean (940ms)  : 897, 982
     .   : milestone, 940,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (266ms)  : 263, 269
     .   : milestone, 266,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section Baseline
    This PR (7560) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (267ms)  : 262, 273
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (923ms)  : 876, 970
     .   : milestone, 923,
    master - mean (920ms)  : 870, 970
     .   : milestone, 920,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7560) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 263, 269
     .   : milestone, 266,

    section Baseline
    This PR (7560) - mean (267ms)  : 262, 272
     .   : milestone, 267,
    master - mean (266ms)  : 263, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7560) - mean (848ms)  : 825, 870
     .   : milestone, 848,
    master - mean (853ms)  : 834, 872
     .   : milestone, 853,
Loading

@gleocadie gleocadie force-pushed the gleocadie/bump-to-libdatadog-21 branch 2 times, most recently from 0e74d35 to e7e8a6c Compare October 2, 2025 07:50
@gleocadie gleocadie mentioned this pull request Oct 2, 2025
Closed
@gleocadie gleocadie force-pushed the gleocadie/bump-to-libdatadog-21 branch from e7e8a6c to cd0cf78 Compare October 3, 2025 07:38
@dmehala
Copy link

dmehala commented Oct 3, 2025

Hey @gleocadie
libdatadog v22.0.0 introduces a breaking change in the process discovery FFI. In case you are facing a compilation issue regarding this API, I have a draft that should solve this issue: #7607

Please let me know if I can help.

@gleocadie gleocadie force-pushed the gleocadie/bump-to-libdatadog-21 branch 2 times, most recently from cadf784 to 74a70a6 Compare October 6, 2025 08:53
@gleocadie
Copy link
Collaborator Author

Hey @gleocadie libdatadog v22.0.0 introduces a breaking change in the process discovery FFI. In case you are facing a compilation issue regarding this API, I have a draft that should solve this issue: #7607

Please let me know if I can help.

Hey, sorry I missed your message @dmehala
I'll use your fixes in my PR and see how it goes
Thanks

@gleocadie gleocadie force-pushed the gleocadie/bump-to-libdatadog-21 branch from 74a70a6 to 3ecb0ba Compare October 6, 2025 08:58
@gleocadie gleocadie force-pushed the gleocadie/bump-to-libdatadog-21 branch 5 times, most recently from fbbeae2 to 2a06b13 Compare October 6, 2025 11:53
@gleocadie gleocadie force-pushed the gleocadie/bump-to-libdatadog-21 branch from 2a06b13 to cca2898 Compare October 6, 2025 12:36
gleocadie and others added 6 commits October 7, 2025 10:18
@gleocadie
Changes according to libdatadog example
66a3bd4
@gleocadie
Add mising logs field
cb0eba4
@gleocadie
Enable by default telemetry on mock agent
5d6a026
@hoolioh
Disable telemetry in trace exporter
259caeb
@hoolioh
Fix test
101414a 
* Disable telemetry by default in the mock agent.
* Enable telemetry explicitely in trace exporter tests.
* Wait for telemetry payloads.
@hoolioh
Refactor test
03afbf1
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7560 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.854
  • 8 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7560

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.03 KB 6 KB -34 B -0.56%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 58.5ns 346ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 13.7μs 43.8ns 170ns 0 0 0 5.71 KB
master StartStopWithChild net472 21.5μs 121ns 785ns 0.867 0.217 0 6.03 KB
#7560 StartStopWithChild net6.0 11μs 37.1ns 144ns 0 0 0 5.5 KB
#7560 StartStopWithChild netcoreapp3.1 13.9μs 50.5ns 195ns 0 0 0 5.72 KB
#7560 StartStopWithChild net472 22.1μs 106ns 474ns 0.982 0.436 0.109 6 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 937μs 202ns 757ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 267ns 1.03μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.18ms 374ns 1.45μs 0 0 0 3.31 KB
#7560 WriteAndFlushEnrichedTraces net6.0 935μs 177ns 637ns 0 0 0 2.71 KB
#7560 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 62.5ns 225ns 0 0 0 2.7 KB
#7560 WriteAndFlushEnrichedTraces net472 1.2ms 1.37μs 5.3μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 361μs 1.08μs 4.19μs 0 0 0 180.01 KB
master AllCycleSimpleBody netcoreapp3.1 534μs 2.27μs 11.1μs 0 0 0 185.8 KB
master AllCycleSimpleBody net472 472μs 132ns 495ns 32.4 0 0 206.3 KB
master AllCycleMoreComplexBody net6.0 365μs 1.53μs 5.72μs 0 0 0 183.53 KB
master AllCycleMoreComplexBody netcoreapp3.1 520μs 1.81μs 7.03μs 0 0 0 189.23 KB
master AllCycleMoreComplexBody net472 480μs 144ns 557ns 32.4 0 0 209.85 KB
master ObjectExtractorSimpleBody net6.0 317ns 1.51ns 5.85ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 397ns 2.2ns 12.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 296ns 0.0214ns 0.077ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.26μs 33.5ns 171ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.84μs 38.1ns 152ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.59μs 1.19ns 4.44ns 0.596 0 0 3.8 KB
#7560 AllCycleSimpleBody net6.0 358μs 233ns 904ns 0 0 0 180.01 KB
#7560 AllCycleSimpleBody netcoreapp3.1 500μs 1.28μs 4.95μs 0 0 0 185.8 KB
#7560 AllCycleSimpleBody net472 470μs 185ns 715ns 32.4 0 0 206.3 KB
#7560 AllCycleMoreComplexBody net6.0 364μs 1.08μs 4.19μs 0 0 0 183.53 KB
#7560 AllCycleMoreComplexBody netcoreapp3.1 545μs 1.21μs 4.67μs 0 0 0 189.23 KB
#7560 AllCycleMoreComplexBody net472 480μs 130ns 487ns 32.4 0 0 209.83 KB
#7560 ObjectExtractorSimpleBody net6.0 318ns 1.72ns 9.24ns 0 0 0 280 B
#7560 ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.24ns 14ns 0 0 0 272 B
#7560 ObjectExtractorSimpleBody net472 302ns 0.0226ns 0.0847ns 0.0441 0 0 281 B
#7560 ObjectExtractorMoreComplexBody net6.0 6.31μs 31.9ns 153ns 0 0 0 3.78 KB
#7560 ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 25.3ns 98.2ns 0 0 0 3.69 KB
#7560 ObjectExtractorMoreComplexBody net472 6.67μs 3.24ns 12.1ns 0.599 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.1μs 318ns 1.23μs 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.4μs 35.1ns 136ns 0 0 0 32.4 KB
master EncodeArgs net472 111μs 13.3ns 51.6ns 5 0 0 32.5 KB
master EncodeLegacyArgs net6.0 145μs 47.8ns 179ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 203μs 452ns 1.75μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 28.4ns 110ns 0 0 0 2.17 KB
#7560 EncodeArgs net6.0 76.7μs 295ns 1.14μs 0 0 0 32.4 KB
#7560 EncodeArgs netcoreapp3.1 96.2μs 385ns 1.49μs 0 0 0 32.4 KB
#7560 EncodeArgs net472 109μs 10.3ns 37.2ns 4.92 0 0 32.51 KB
#7560 EncodeLegacyArgs net6.0 145μs 102ns 395ns 0 0 0 2.15 KB
#7560 EncodeLegacyArgs netcoreapp3.1 200μs 234ns 908ns 0 0 0 2.14 KB
#7560 EncodeLegacyArgs net472 264μs 61.9ns 223ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7560

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.487 296,060.98 736,402.23
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 1.381 625,396.77 863,971.07

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 392μs 43.3ns 162ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 625μs 237ns 820ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 55.3ns 207ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 286μs 37ns 133ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 296μs 104ns 390ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 311μs 22.1ns 79.8ns 0 0 0 2.29 KB
#7560 RunWafRealisticBenchmark net6.0 395μs 125ns 468ns 0 0 0 4.56 KB
#7560 RunWafRealisticBenchmark netcoreapp3.1 816μs 13.8μs 138μs 0 0 0 4.48 KB
#7560 RunWafRealisticBenchmark net472 427μs 31.3ns 117ns 0 0 0 4.66 KB
#7560 RunWafRealisticBenchmarkWithAttack net6.0 284μs 41.8ns 162ns 0 0 0 2.24 KB
#7560 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 681μs 13.8μs 138μs 0 0 0 2.22 KB
#7560 RunWafRealisticBenchmarkWithAttack net472 311μs 29.1ns 109ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 35.7ns 134ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.2μs 236ns 1.18μs 0 0 0 17.42 KB
master SendRequest net472 0.00371ns 0.00131ns 0.00507ns 0 0 0 0 b
#7560 SendRequest net6.0 61.5μs 40.8ns 141ns 0 0 0 14.52 KB
#7560 SendRequest netcoreapp3.1 71.6μs 156ns 582ns 0 0 0 17.42 KB
#7560 SendRequest net472 0.00203ns 0.00121ns 0.00469ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7560

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 4 B 2 B -2 B -50.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 2 B 1 B -1 B -50.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 3 B 0 b -3 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 0 b -47 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.85ms 5.78μs 21.6μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.16ms 3.59μs 13.4μs 0 0 0 640 KB
master OriginalCharSlice net472 2.67ms 274ns 1.06μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.39ms 311ns 1.2μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.67ms 626ns 2.42μs 0 0 0 1 B
master OptimizedCharSlice net472 2ms 514ns 1.99μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 863μs 58.8ns 228ns 0 0 0 2 B
master OptimizedCharSliceWithPool netcoreapp3.1 814μs 204ns 789ns 0 0 0 3 B
master OptimizedCharSliceWithPool net472 1.13ms 120ns 450ns 0 0 0 47 B
#7560 OriginalCharSlice net6.0 1.93ms 709ns 2.75μs 0 0 0 640.01 KB
#7560 OriginalCharSlice netcoreapp3.1 2.15ms 10.4μs 37.5μs 0 0 0 640 KB
#7560 OriginalCharSlice net472 2.71ms 2.65μs 10.3μs 100 0 0 641.95 KB
#7560 OptimizedCharSlice net6.0 1.51ms 403ns 1.56μs 0 0 0 2 B
#7560 OptimizedCharSlice netcoreapp3.1 1.75ms 403ns 1.51μs 0 0 0 1 B
#7560 OptimizedCharSlice net472 1.95ms 300ns 1.16μs 0 0 0 0 b
#7560 OptimizedCharSliceWithPool net6.0 819μs 123ns 477ns 0 0 0 1 B
#7560 OptimizedCharSliceWithPool netcoreapp3.1 811μs 39.8ns 149ns 0 0 0 0 b
#7560 OptimizedCharSliceWithPool net472 1.13ms 108ns 420ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7560

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.82 KB 42.1 KB 287 B 0.69%

Fewer allocations 🎉 in #7560

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.25 KB 41.9 KB -344 B -0.81%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 696μs 826ns 2.98μs 0 0 0 41.82 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 757μs 4.2μs 25.5μs 0 0 0 42.25 KB
master WriteAndFlushEnrichedTraces net472 985μs 4.74μs 19.5μs 4.46 0 0 56.04 KB
#7560 WriteAndFlushEnrichedTraces net6.0 647μs 800ns 3.1μs 0 0 0 42.1 KB
#7560 WriteAndFlushEnrichedTraces netcoreapp3.1 724μs 4.18μs 33.5μs 0 0 0 41.9 KB
#7560 WriteAndFlushEnrichedTraces net472 902μs 4.48μs 18.5μs 8.33 0 0 55.98 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 6.01ns 23.3ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.61μs 8.48ns 31.7ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 3.02μs 3.85ns 14.9ns 0.153 0.0153 0 987 B
#7560 ExecuteNonQuery net6.0 2.01μs 3.59ns 13.9ns 0 0 0 1.02 KB
#7560 ExecuteNonQuery netcoreapp3.1 2.59μs 10.6ns 41.2ns 0 0 0 1.02 KB
#7560 ExecuteNonQuery net472 2.77μs 2.76ns 10.7ns 0.153 0.0139 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.78μs 8.99ns 43.1ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.29μs 3.87ns 14.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.71μs 3.66ns 14.2ns 0.165 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.86μs 1.23ns 4.27ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.42μs 12ns 53.7ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.79μs 3.37ns 13ns 0.169 0 0 1.1 KB
#7560 CallElasticsearch net6.0 1.77μs 8.72ns 37ns 0 0 0 1.03 KB
#7560 CallElasticsearch netcoreapp3.1 2.28μs 8.18ns 31.7ns 0 0 0 1.03 KB
#7560 CallElasticsearch net472 3.48μs 6.04ns 23.4ns 0.157 0 0 1.04 KB
#7560 CallElasticsearchAsync net6.0 1.88μs 7.21ns 27.9ns 0 0 0 1.01 KB
#7560 CallElasticsearchAsync netcoreapp3.1 2.42μs 5.94ns 23ns 0 0 0 1.08 KB
#7560 CallElasticsearchAsync net472 3.76μs 8.42ns 32.6ns 0.167 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.87μs 7.85ns 30.4ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.37μs 3.58ns 13.9ns 0 0 0 952 B
master ExecuteAsync net472 2.59μs 4.93ns 19.1ns 0.141 0 0 915 B
#7560 ExecuteAsync net6.0 1.81μs 2.08ns 7.78ns 0 0 0 952 B
#7560 ExecuteAsync netcoreapp3.1 2.34μs 10.6ns 41.2ns 0 0 0 952 B
#7560 ExecuteAsync net472 2.62μs 3.95ns 15.3ns 0.144 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.81μs 10.1ns 37.7ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.55μs 4.67ns 18.1ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.2ns 39.6ns 0.502 0 0 3.18 KB
#7560 SendAsync net6.0 6.73μs 4.55ns 17ns 0 0 0 2.36 KB
#7560 SendAsync netcoreapp3.1 8.7μs 21.9ns 84.8ns 0 0 0 2.9 KB
#7560 SendAsync net472 12.5μs 9.66ns 37.4ns 0.499 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7560

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 260.65 KB 275.94 KB 15.29 KB 5.87%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.78 KB 44.04 KB 1.26 KB 2.94%

Fewer allocations 🎉 in #7560

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 42.1μs 241ns 1.58μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 50.8μs 295ns 2.72μs 0 0 0 42.78 KB
master StringConcatBenchmark net472 57.4μs 114ns 411ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 489μs 8.53μs 85.3μs 0 0 0 278.03 KB
master StringConcatAspectBenchmark netcoreapp3.1 531μs 1.02μs 3.82μs 0 0 0 260.65 KB
master StringConcatAspectBenchmark net472 403μs 2.11μs 10.4μs 0 0 0 286.72 KB
#7560 StringConcatBenchmark net6.0 43.8μs 218ns 1.36μs 0 0 0 43.88 KB
#7560 StringConcatBenchmark netcoreapp3.1 49.1μs 240ns 962ns 0 0 0 44.04 KB
#7560 StringConcatBenchmark net472 56.2μs 235ns 911ns 0 0 0 65.54 KB
#7560 StringConcatAspectBenchmark net6.0 471μs 2.03μs 7.32μs 0 0 0 277.44 KB
#7560 StringConcatAspectBenchmark netcoreapp3.1 526μs 1.12μs 4.05μs 0 0 0 275.94 KB
#7560 StringConcatAspectBenchmark net472 408μs 2.15μs 11μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.59μs 3.61ns 14ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.74μs 10.7ns 41.6ns 0 0 0 1.7 KB
master EnrichedLog net472 3.77μs 1.43ns 5.52ns 0.245 0 0 1.64 KB
#7560 EnrichedLog net6.0 2.63μs 12ns 45.1ns 0 0 0 1.7 KB
#7560 EnrichedLog netcoreapp3.1 3.62μs 3.55ns 13.8ns 0 0 0 1.7 KB
#7560 EnrichedLog net472 3.79μs 1.8ns 6.23ns 0.246 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 103ns 370ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 106ns 383ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 101ns 390ns 0 0 0 4.52 KB
#7560 EnrichedLog net6.0 124μs 356ns 1.38μs 0 0 0 4.31 KB
#7560 EnrichedLog netcoreapp3.1 130μs 111ns 416ns 0 0 0 4.31 KB
#7560 EnrichedLog net472 166μs 63.1ns 236ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.92μs 4.36ns 16.3ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.72μs 24.1ns 93.3ns 0 0 0 2.26 KB
master EnrichedLog net472 7.55μs 9.82ns 38ns 0.302 0 0 2.08 KB
#7560 EnrichedLog net6.0 5.01μs 8.08ns 29.1ns 0 0 0 2.26 KB
#7560 EnrichedLog netcoreapp3.1 6.98μs 13.4ns 51.8ns 0 0 0 2.26 KB
#7560 EnrichedLog net472 7.47μs 5.22ns 20.2ns 0.3 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.01μs 9.89ns 43.1ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.53μs 12.9ns 64.7ns 0 0 0 1.2 KB
master SendReceive net472 3.3μs 7.07ns 27.4ns 0.18 0 0 1.2 KB
#7560 SendReceive net6.0 1.96μs 10.3ns 49.3ns 0 0 0 1.2 KB
#7560 SendReceive netcoreapp3.1 2.67μs 5.63ns 21.8ns 0 0 0 1.2 KB
#7560 SendReceive net472 3.19μs 6.41ns 24.8ns 0.189 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.28μs 6.07ns 22.7ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.62μs 5.44ns 21.1ns 0 0 0 1.63 KB
master EnrichedLog net472 6.7μs 6.11ns 23.7ns 0.301 0 0 2.03 KB
#7560 EnrichedLog net6.0 4.27μs 5.92ns 22.2ns 0 0 0 1.58 KB
#7560 EnrichedLog netcoreapp3.1 5.68μs 12ns 44.9ns 0 0 0 1.63 KB
#7560 EnrichedLog net472 6.85μs 5.2ns 20.1ns 0.305 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 763ns 0.259ns 1ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 954ns 4.55ns 17.6ns 0 0 0 576 B
master StartFinishSpan net472 904ns 0.74ns 2.87ns 0.0913 0 0 578 B
master StartFinishScope net6.0 907ns 4.84ns 24.2ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 0.895ns 3.35ns 0 0 0 696 B
master StartFinishScope net472 1.16μs 0.948ns 3.55ns 0.0995 0 0 658 B
#7560 StartFinishSpan net6.0 765ns 0.339ns 1.31ns 0 0 0 576 B
#7560 StartFinishSpan netcoreapp3.1 934ns 5.03ns 29.3ns 0 0 0 576 B
#7560 StartFinishSpan net472 920ns 0.253ns 0.948ns 0.0916 0 0 578 B
#7560 StartFinishScope net6.0 905ns 4.63ns 20.7ns 0 0 0 696 B
#7560 StartFinishScope netcoreapp3.1 1.2μs 6.54ns 34.6ns 0 0 0 696 B
#7560 StartFinishScope net472 1.11μs 0.45ns 1.62ns 0.0996 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.06μs 5.67ns 29.5ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 6.9ns 27.6ns 0 0 0 696 B
master RunOnMethodBegin net472 1.41μs 1.61ns 6.03ns 0.0991 0 0 658 B
#7560 RunOnMethodBegin net6.0 1.05μs 5.29ns 23.6ns 0 0 0 696 B
#7560 RunOnMethodBegin netcoreapp3.1 1.44μs 5.98ns 23.2ns 0 0 0 696 B
#7560 RunOnMethodBegin net472 1.43μs 2.25ns 8.7ns 0.1 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gleocadie @dmehala @hoolioh