feat: Add flushing destructor for Tracer #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rational: In short lived applications (e.g. Kubernetes Jobs) most of the time all traces get lost becasue they are not synced. Users need to call `Close` manually, but as all spans hold a shared_ptr on the tracer it is hard to have the correct place to call it. Calling it in the destructor assures all spans will be included in the flush.
DS-Serafin
force-pushed
the
feature/close-tracer-in-destructor
branch
from
9c17001 to
b0da0cd
Compare
|
Not sure what the failing integration tests wants to say to me. Looks to be unrelated to my change? |
|
The integration test failures are caused by this change, but it's a bit subtle why. I'm playing with it in #250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational: In short lived applications (e.g. Kubernetes Jobs) most of the time all traces get lost becasue they are not synced. Users need to call
Closemanually, but as all spans hold a shared_ptr on the tracer it is hard to have the correct place to call it. Calling it in the destructor assures all spans will be included in the flush.