Skip to content

Conversation

cgilmour
Copy link
Contributor

@cgilmour cgilmour commented Aug 8, 2019

Under some circumstances, envoy adds the http.status_code tag with a value that isn't permitted by Datadog.
Although invalid values are detected in newer versions of the agent, and corrected by removing that tag from the span, it's better if it doesn't occur at all.

This PR ignores the http.status_code tag if the value is "0".

@palazzem palazzem self-requested a review August 9, 2019 09:34
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but lets hold until we can confirm why we are seeing status code of 0 and if that is actually an issue or not.

@cgilmour
Copy link
Contributor Author

Assuming we confirm this, should the span be tagged as an error?
It might not be a confirmed 5xx, but it's likely something went wrong-enough to report an error flag.

@palazzem
Copy link

@cgilmour it depends on the meaning of the field. If the fact it is not reported is because of an error (and so Envoy bails out before assigning an HTTP status code) then yes. If it's really generic and it happens also for legit reasons, it should not be considered an error.

@cgilmour cgilmour added this to the 1.1.0 milestone Aug 25, 2019
@dgoffredo
Copy link
Contributor

Happy 2021. Is this feature needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants