DO NOT import requests from botocore

[tianchu]

What does this PR do?

Remove the fallback way to import requests from botocore.

The Datadog Forwarder no longer depends on the requests module from botocore.vendored since v2.3.2, but the import statement was kept as a fallback to help customers upgrade their forwarders by copying the source code (that used to be the easiest way to upgrade until CloudFormation was adopted, see this PR).

That fallback import statement will soon become obsolete, and it probably triggered the communications (false alarms, since it's only a fallback) from AWS to customers.

Motivation

Testing Guidelines

Additional Notes

Types of changes

• Bug fix
• New feature
• Breaking change
• Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

• This PR's description is comprehensive
• This PR contains breaking changes that are documented in the description
• This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
• This PR impacts documentation, and it has been updated (or a ticket has been logged)
• This PR's changes are covered by the automated tests
• This PR collects user input/sensitive content into Datadog
• This PR passes the integration tests (ask a Datadog member to run the tests)
• This PR passes the unit tests
• This PR passes the installation tests (ask a Datadog member to run the tests)

[agocs]

LGTM. Are we going to bump the major version to signify what's technically a breaking change?

[tianchu]

LGTM. Are we going to bump the major version to signify what's technically a breaking change?

I don't think so -- it's a breaking change only when upgrading from a 2.x version to the latest 3.x, the major version bump from 2 to 3 already reflects it.