Skip to content

Run cfn-lint against the AWS Datadog Forwarder CloudFormation Template #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianchu merged 2 commits into from
Mar 19, 2020
Merged

Run cfn-lint against the AWS Datadog Forwarder CloudFormation Template #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba4d5dc
Add cfn-lint
tianchu Mar 19, 2020
73cc526
Fix integration test snapshots
tianchu Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/cfn-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: cfn-lint

on: [pull_request]

jobs:
cfn-lint:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v2

- name: cfn-lint
uses: docker://scottbrenner/cfn-lint-action:latest
with:
args: "aws/logs_monitoring/template.yaml"
2 changes: 1 addition & 1 deletion .github/workflows/lambdachecks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Lambda checks

on: [push]
on: [pull_request]

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions aws/logs_monitoring/tests/snapshots/cloudwatch_log.json~snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"invoked_function_arn": "arn:aws:lambda:us-east-1:0:function:test"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0",
"ddsource": "cloudwatch",
"service": "cloudwatch",
"host": "testLogGroup"
Expand All @@ -38,7 +38,7 @@
"invoked_function_arn": "arn:aws:lambda:us-east-1:0:function:test"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0",
"ddsource": "cloudwatch",
"service": "cloudwatch",
"host": "testLogGroup"
Expand Down
32 changes: 16 additions & 16 deletions aws/logs_monitoring/tests/snapshots/cloudwatch_log_lambda_invocation.json~snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -44,7 +44,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -66,7 +66,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -88,7 +88,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -110,7 +110,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -132,7 +132,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -154,7 +154,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -176,7 +176,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -198,7 +198,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -220,7 +220,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -242,7 +242,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -264,7 +264,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -286,7 +286,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -308,7 +308,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -330,7 +330,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand All @@ -352,7 +352,7 @@
"arn": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
},
"ddsourcecategory": "aws",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.3.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddtags": "forwardername:test,forwarder_memorysize:1536,forwarder_version:3.4.0,env:none,account_id:0,aws_account:0,functionname:hello-dog-node-dev-hello12x,region:us-east-1",
"ddsource": "lambda",
"service": "hello-dog-node-dev-hello12x",
"host": "arn:aws:lambda:us-east-1:0:function:hello-dog-node-dev-hello12x"
Expand Down