support for secrets manager on logs monitoring #185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key from secrets manager
Contributor
|
Hi @realanmup thanks for your PR! We already have this feature implemented in another WIP PR #171, which will get released soon. Feel free to comment on that PR if anything diffs from your expectation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A condition is added to get Datadog Api Key from secrets manager using environment variable DD_API_KEY_SECRET_ARN.
Motivation
Lambda layer which needs to be implemented with this lambda function already contains this feature. I was using this code for a project and got stuck for a day because we were using AWS Secrets Manager.