-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add support for Ruby 3.2 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
allow ARM builds and Ruby 3.2 support
also to add new region and check layer size
to ensure it works as expected for 3.2
Integration test failed during docker build 0.234 exec /bin/sh: exec format error
#9 ERROR: executor failed running [/bin/sh -c apt-get update]: exit code: 1 I think this is usually from a mismatch between the architectures of the image and the host?
|
integration_tests/snapshots/return_values/async-metrics_ruby32_api-gateway-get.json
Outdated
Show resolved
Hide resolved
this will check if an extension is running, if it is, it will send logs, traces, and metrics through it. This doesnt introduce a regression for customers using the forwarder
also updated snapshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job on this Jordan!
Avoid overhead of creating the URL on every invocation of the `extension_running` check Co-authored-by: Marco Costa <[email protected]>
|
||
# Run the image by runtime tag, tar its generatd `ruby` directory to sdout, | ||
# then extract it to a temp directory. | ||
docker run --rm datadog-lambda-layer-ruby:$1 tar cf - /opt/ruby | tar -xf - -C $temp_dir | ||
docker run --rm datadog-lambda-ruby-${arch}:$1 tar cf - /opt/ruby | tar -xf - -C $temp_dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only ship /opt/ruby
to the client? Nothing else is needed for the layer? @duncanista
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct, since this layer is later merged in the AWS Lambda runtime /opt/ruby
, this is enough to make it work!
What does this PR do?
Updates gem to work with Ruby 3.2.
Motivation
AWS posted an image of AWS Lambda for Ruby 3.2 in their ECR gallery. And users have also raised an issue about the gem needed small changes to work.
#70
#74
Testing Guidelines
Additional Notes
Types of changes
Check all that apply