Skip to content

Don't send x-ray trace metadata for when x-ray has filtered trace #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

DarcyRaynerDD
Copy link
Contributor

What does this PR do?

When writing the datadog metadata subsegment to x-ray, check the trace hasn't already been sampled.

Motivation

Prevents sending redundant traces to x-ray in the case where user's have at some point turned on active tracing to their function.

Testing Guidelines

I added a unit test, and tested this manually.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner November 8, 2021 20:56
@DarcyRaynerDD DarcyRaynerDD merged commit 8556eb5 into main Nov 8, 2021
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-xray-sampling branch November 8, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants